qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v4 0/7] TCG global variables clean-up
@ 2012-10-31  5:19 Evgeny Voevodin
  2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 1/7] target-cris/translate.c: Code style clean-up Evgeny Voevodin
                   ` (7 more replies)
  0 siblings, 8 replies; 11+ messages in thread
From: Evgeny Voevodin @ 2012-10-31  5:19 UTC (permalink / raw)
  To: qemu-devel
  Cc: Evgeny Voevodin, blauwirbel, kyungmin.park, edgar.iglesias,
	aurelien, rth

This set of patches moves global variables to tcg_ctx:
gen_opc_ptr
gen_opparam_ptr
gen_opc_buf
gen_opparam_buf

Build tested for all targets.
Execution tested on Exynos4210 target.

After this patchset was aplied, I noticed 0.7% speed-up of code generation.
Probably, this is due to better data caching.

Here is the test procedure:
1. Boot Linux Kernel 5 times.
2. For each iteration wait while "JIT cycles" is stable for ~10 seconds
3. Write down the "cycles/op"

Here are the results (tested on gcc-4.6):

Before clean-up:
min: 731.5
max: 734.8
avg: 733.0
standard deviation: ~2 ~= 0.2%

Average cycles/op = 733 +- 2



After clean-up:
min: 725.0
max: 730.5
avg: 727.8
standard deviation: ~3 ~= 0.4%

Average cycles/op = 728 +- 3
Speed-up of TCG code generation = 0.7%

Changelog:
v3->v4:
Rebased.
Added target-cris/translate.c: Code style clean-up
v2->v3:
Removed tcg_cur_ctx since it gives slow-down on gcc-4.5.
Rebased.
v1->v2:
Introduced TCGContext *tcg_cur_ctx global to use in those places where we don't
have an interface to pass pointer to tcg_ctx.
Code style clean-up

Evgeny (2):
  tcg/tcg.h: Duplicate global TCG variables in TCGContext
  TCG: Remove unused global variables

Evgeny Voevodin (5):
  target-cris/translate.c: Code style clean-up
  TCG: Use gen_opc_ptr from context instead of global variable.
  TCG: Use gen_opparam_ptr from context instead of global variable.
  TCG: Use gen_opc_buf from context instead of global variable.
  TCG: Use gen_opparam_buf from context instead of global variable.

 gen-icount.h                  |    2 +-
 target-alpha/translate.c      |   10 +-
 target-arm/translate.c        |   10 +-
 target-cris/translate.c       | 5041 +++++++++++++++++++++--------------------
 target-i386/translate.c       |   10 +-
 target-lm32/translate.c       |   13 +-
 target-m68k/translate.c       |   10 +-
 target-microblaze/translate.c |   13 +-
 target-mips/translate.c       |   11 +-
 target-openrisc/translate.c   |   13 +-
 target-ppc/translate.c        |   11 +-
 target-s390x/translate.c      |   11 +-
 target-sh4/translate.c        |   10 +-
 target-sparc/translate.c      |   10 +-
 target-unicore32/translate.c  |   10 +-
 target-xtensa/translate.c     |    8 +-
 tcg/optimize.c                |   62 +-
 tcg/tcg-op.h                  |  324 +--
 tcg/tcg.c                     |   85 +-
 tcg/tcg.h                     |   10 +-
 translate-all.c               |    3 -
 21 files changed, 2860 insertions(+), 2817 deletions(-)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2012-11-03  9:43 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-31  5:19 [Qemu-devel] [PATCH v4 0/7] TCG global variables clean-up Evgeny Voevodin
2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 1/7] target-cris/translate.c: Code style clean-up Evgeny Voevodin
2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 2/7] tcg/tcg.h: Duplicate global TCG variables in TCGContext Evgeny Voevodin
2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 3/7] TCG: Use gen_opc_ptr from context instead of global variable Evgeny Voevodin
2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 4/7] TCG: Use gen_opparam_ptr " Evgeny Voevodin
2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 5/7] TCG: Use gen_opc_buf " Evgeny Voevodin
2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 6/7] TCG: Use gen_opparam_buf " Evgeny Voevodin
2012-10-31  5:19 ` [Qemu-devel] [PATCH v4 7/7] TCG: Remove unused global variables Evgeny Voevodin
2012-10-31 19:01 ` [Qemu-devel] [PATCH v4 0/7] TCG global variables clean-up Richard Henderson
2012-11-02  5:06   ` Evgeny Voevodin
2012-11-03  9:42     ` Blue Swirl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).