From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/qxl: vaildate surface->data
Date: Thu, 01 Nov 2012 10:33:41 +0100 [thread overview]
Message-ID: <509241F5.8070605@redhat.com> (raw)
In-Reply-To: <1351168048-29190-1-git-send-email-alevy@redhat.com>
On 10/25/12 14:27, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
Looks sane at a quick glance.
But: how far we wanna take this? Add checks to qxl for each and every
assert() guests can trigger in spice-server? So we end up
sanity-checking everything twice long-term?
I think instead we'll need a way for spice-server to report back errors
to qxl. So spice-server would just notify qxl and go on (or stop
processing until reset) instead of aborting. qxl in turn will notify
the guest.
[ The alternative would be to basically move server/red_parse_qxl.c
into the qemu codebase. I don't think we want that because that
would make a bunch of data structures which are spice-server internal
today (for good reasons) a libspice-server ABI+API. ]
cheers,
Gerd
next prev parent reply other threads:[~2012-11-01 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 12:27 [Qemu-devel] [PATCH] hw/qxl: vaildate surface->data Alon Levy
2012-11-01 9:33 ` Gerd Hoffmann [this message]
2012-11-01 9:43 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509241F5.8070605@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).