qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state
Date: Thu, 01 Nov 2012 10:55:53 +0100	[thread overview]
Message-ID: <50924729.3090101@redhat.com> (raw)
In-Reply-To: <1641209605.25277085.1351763131761.JavaMail.root@redhat.com>

  Hi,

>> IMO spice-server must not call interface_client_set_capabilities
>> when the vm is not running.  After all we notify spice-server about
>> the vm stop/start events for a reason ...
> 
> OK, I agree that should be fixed, we can queue this until the vm
> starts running in spice-server. But having an assert on notify in
> qemu is also wrong - and the only way to fix it like you pointed out
> without dropping the event is to queue it as well.
> 
> So which will it be, queue in spice or in qemu? qemu seems a simpler
> place to catch everything.

When queuing in qemu you are facing the migration issue again in a
different way:  Just this time it isn't guest state, but a qxl register.
 Not guest visible, but still state which must be migrated over ...

cheers,
  Gerd

  reply	other threads:[~2012-11-01  9:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 12:53 [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state Alon Levy
2012-11-01  9:19 ` Gerd Hoffmann
2012-11-01  9:45   ` Alon Levy
2012-11-01  9:55     ` Gerd Hoffmann [this message]
2012-11-01 10:22       ` Alon Levy
2012-11-01 10:33         ` Gerd Hoffmann
2012-11-01 11:48           ` Alon Levy
2012-11-01 12:32             ` Gerd Hoffmann
2012-11-01 12:44               ` Alon Levy
2012-11-01 12:47                 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50924729.3090101@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).