From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions
Date: Thu, 01 Nov 2012 11:08:47 +0100 [thread overview]
Message-ID: <50924A2F.7090706@redhat.com> (raw)
In-Reply-To: <1351687636-14253-2-git-send-email-hdegoede@redhat.com>
On 10/31/12 13:47, Hans de Goede wrote:
> + /*
> + * If we had leftover packets the hcd driver will have cancelled them
> + * and usb_combined_packet_cancel has already freed combined!
> + */
> + if (state != leftover) {
> + g_free(combined);
> + }
This calls for reference-counting USBCombinedPacket IMHO.
cheers,
Gerd
next prev parent reply other threads:[~2012-11-01 10:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 12:47 [Qemu-devel] usb input pipelining patches v3 Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions Hans de Goede
2012-11-01 10:08 ` Gerd Hoffmann [this message]
2012-11-01 13:14 ` Hans de Goede
2012-11-01 13:28 ` Hans de Goede
2012-11-01 13:59 ` Hans de Goede
2012-11-01 14:23 ` Gerd Hoffmann
2012-11-01 16:17 ` Hans de Goede
2012-11-01 16:42 ` Gerd Hoffmann
2012-11-01 19:07 ` Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 2/8] combined-packet: Add a workaround for Linux usbfs + live migration Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 3/8] usb-redir: Add support for 32 bits bulk packet length Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 4/8] usb-redir: Add support for input pipelining Hans de Goede
2012-11-01 10:10 ` Gerd Hoffmann
2012-11-01 13:16 ` Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 5/8] usb-redir: Add an usbredir_setup_usb_eps() helper function Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 6/8] usb-redir: Use reject rather the disconnect on bad ep info Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 7/8] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller Hans de Goede
2012-10-31 12:47 ` [Qemu-devel] [PATCH 8/8] usb-redir: Allow redirecting super speed devices to high speed controllers Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50924A2F.7090706@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).