From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40449)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTrhl-0004Dc-Os
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 06:08:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTrhh-000796-TQ
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 06:08:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTrhh-00078w-Km
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 06:08:49 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA1A8mgE006530
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 1 Nov 2012 06:08:49 -0400
Message-ID: <50924A2F.7090706@redhat.com>
Date: Thu, 01 Nov 2012 11:08:47 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1351687636-14253-1-git-send-email-hdegoede@redhat.com>
	<1351687636-14253-2-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1351687636-14253-2-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/31/12 13:47, Hans de Goede wrote:
> +    /*
> +     * If we had leftover packets the hcd driver will have cancelled them
> +     * and usb_combined_packet_cancel has already freed combined!
> +     */
> +    if (state != leftover) {
> +        g_free(combined);
> +    }

This calls for reference-counting USBCombinedPacket IMHO.

cheers,
  Gerd