From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state
Date: Thu, 01 Nov 2012 13:32:47 +0100 [thread overview]
Message-ID: <50926BEF.3000709@redhat.com> (raw)
In-Reply-To: <1786113489.25327079.1351770480060.JavaMail.root@redhat.com>
On 11/01/12 12:48, Alon Levy wrote:
> + if (!qemu_spice_display_is_running(&d->ssd)) {
> + fprintf(stderr, "%s: guest stopped, ignoring\n", __func__);
> + trace_qxl_send_events_vm_stopped(d->id, events);
> + return;
> + }
Almost perfect. We should add a note here that this happening is a
spice server bug, at least as source code comment, maybe also in the
fprintf.
cheers,
Gerd
next prev parent reply other threads:[~2012-11-01 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 12:53 [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state Alon Levy
2012-11-01 9:19 ` Gerd Hoffmann
2012-11-01 9:45 ` Alon Levy
2012-11-01 9:55 ` Gerd Hoffmann
2012-11-01 10:22 ` Alon Levy
2012-11-01 10:33 ` Gerd Hoffmann
2012-11-01 11:48 ` Alon Levy
2012-11-01 12:32 ` Gerd Hoffmann [this message]
2012-11-01 12:44 ` Alon Levy
2012-11-01 12:47 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50926BEF.3000709@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).