From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33903)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTuBo-0007dO-Um
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 08:48:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTuBn-0001bA-NN
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 08:48:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39143)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTuBn-0001b0-Ed
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 08:48:03 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA1Cm2j5018308
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 1 Nov 2012 08:48:02 -0400
Message-ID: <50926F7F.9060103@redhat.com>
Date: Thu, 01 Nov 2012 13:47:59 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <2016872320.25352175.1351773842819.JavaMail.root@redhat.com>
In-Reply-To: <2016872320.25352175.1351773842819.JavaMail.root@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 11/01/12 13:44, Alon Levy wrote:
>> On 11/01/12 12:48, Alon Levy wrote:
>>> +    if (!qemu_spice_display_is_running(&d->ssd)) {
>>> +        fprintf(stderr, "%s: guest stopped, ignoring\n",
>>> __func__);
>>> +        trace_qxl_send_events_vm_stopped(d->id, events);
>>> +        return;
>>> +    }
>>
>> Almost perfect.  We should add a note here that this happening is a
>> spice server bug, at least as source code comment, maybe also in the
>> fprintf.
>>
>> cheers,
>>   Gerd
>>
> 
> 
> commit 49072da137e3d2d86449082e152b0717e5e94672
> Author: Alon Levy <alevy@redhat.com>
> Date:   Tue Oct 30 18:00:33 2012 +0200
> 
>     hw/qxl: qxl_send_events: nop if stopped

Now I need that in 'git send-email' format so I can 'git am' it.  Or
push to git://people.freedesktop.org/~alon/qemu so I can 'git
cherry-pick' from there.

thanks,
  Gerd