From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TTubC-0001G8-PJ
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:14:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TTubB-0000Gi-OK
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:14:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TTubB-0000GY-Ft
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:14:17 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA1DEGvP011801
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 1 Nov 2012 09:14:17 -0400
Message-ID: <50927614.8040309@redhat.com>
Date: Thu, 01 Nov 2012 14:16:04 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1351687636-14253-1-git-send-email-hdegoede@redhat.com>
	<1351687636-14253-5-git-send-email-hdegoede@redhat.com>
	<50924AAA.4000401@redhat.com>
In-Reply-To: <50924AAA.4000401@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/8] usb-redir: Add support for input
	pipelining
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Hi,

On 11/01/2012 11:10 AM, Gerd Hoffmann wrote:
> On 10/31/12 13:47, Hans de Goede wrote:
>> +        if (p->combined) {
>> +            iov_to_buf(p->combined->iov.iov, p->combined->iov.niov,
>> +                       0, buf, size);
>> +        } else {
>> +            usb_packet_copy(p, buf, size);
>> +        }
>
> Should we make usb_packet_copy & friends aware of combined packets?

That sounds like something worth looking into, but can we please first
get this merged as is, and then do that as a follow up patch?

I'll put doing this on my to-do list.

Thanks & Regards,

Hans