From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38905)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTuhP-0003gY-UN
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:20:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTuhL-0002Ss-27
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:20:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20493)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TTuhK-0002Sl-Pb
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:20:38 -0400
Message-ID: <50927722.7040007@redhat.com>
Date: Thu, 01 Nov 2012 14:20:34 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1351240148-13723-1-git-send-email-mail@sebastianbauer.info>
	<1351240148-13723-2-git-send-email-mail@sebastianbauer.info>
	<508A7B69.8050003@redhat.com>
	<2c7709acb10525c7c9365fabe1216e7a@sebastianbauer.info>
In-Reply-To: <2c7709acb10525c7c9365fabe1216e7a@sebastianbauer.info>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is
 switched to the running mode, set the ccs bit for each port,
 to which a device is already attached.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Bauer <mail@sebastianbauer.info>
Cc: qemu-devel@nongnu.org


  Hi,

[ sorry for the delay, was busy with other stuff ]

> I'm not sure about that. According to the spec, when the hc is set to
> running mode (p.70)
> 
> "At this point, the host controller is up and running and the Root Hub
> ports (5.4.8) will begin reporting device
> connects"

I understand "report" as "stick events into the event ring".

So I think the portsc register should be updated no matter what, and
when xhci is running additionally queue an event.

> However, does
> this commit also ensure that the status port change event is generated
> when the hc is switched to running mode and there were already some
> devices present?

No.  I don't think the controller is supposed to do that.

cheers,
  Gerd