From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTv5n-0007OP-SF for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:45:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTv5m-00026O-Mq for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:45:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTv5m-00026H-E3 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:45:54 -0400 Message-ID: <50927D0B.1070603@redhat.com> Date: Thu, 01 Nov 2012 15:45:47 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1351597670-23031-1-git-send-email-avi@redhat.com> <1351597670-23031-4-git-send-email-avi@redhat.com> <5090FE22.9080403@redhat.com> <1351709961.12271.206.camel@pasglop> <50927CB3.6020804@redhat.com> In-Reply-To: <50927CB3.6020804@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/7] memory: iommu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Alex Williamson , Anthony Liguori On 11/01/2012 03:44 PM, Avi Kivity wrote: > > However we do have a problem with non-1/2/4/8 byte writes. Right now > any mismatched access ends up as an 8 byte write, we need an extra > accessor for arbitrary writes, or rather better use of the .impl members > of MemoryRegionOps. Sorry, it's converted into a series of 8-bit writes. So the code is correct now, if inefficient. -- error compiling committee.c: too many arguments to function