From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTwxN-0006Pb-17 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 11:45:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTwxI-0005BX-VE for qemu-devel@nongnu.org; Thu, 01 Nov 2012 11:45:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTwxI-0005B8-MH for qemu-devel@nongnu.org; Thu, 01 Nov 2012 11:45:16 -0400 Message-ID: <50929902.9050002@redhat.com> Date: Thu, 01 Nov 2012 17:45:06 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1351468127-15025-1-git-send-email-pingfank@linux.vnet.ibm.com> <1351468127-15025-6-git-send-email-pingfank@linux.vnet.ibm.com> <508E4D45.5060106@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liu ping fan Cc: Peter Maydell , Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, Anthony Liguori , Stefan Hajnoczi , Paolo Bonzini On 10/29/2012 11:46 AM, liu ping fan wrote: > On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity wrote: >> On 10/29/2012 01:48 AM, Liu Ping Fan wrote: >>> For those address spaces which want to be able out of big lock, they >>> will be protected by their own local. >>> >>> Signed-off-by: Liu Ping Fan >>> --- >>> memory.c | 11 ++++++++++- >>> memory.h | 5 ++++- >>> 2 files changed, 14 insertions(+), 2 deletions(-) >>> >>> diff --git a/memory.c b/memory.c >>> index 2f68d67..ff34aed 100644 >>> --- a/memory.c >>> +++ b/memory.c >>> @@ -1532,9 +1532,15 @@ void memory_listener_unregister(MemoryListener *listener) >>> QTAILQ_REMOVE(&memory_listeners, listener, link); >>> } >>> >>> -void address_space_init(AddressSpace *as, MemoryRegion *root) >>> +void address_space_init(AddressSpace *as, MemoryRegion *root, bool lock) >> >> >> Why not always use the lock? Even if the big lock is taken, it doesn't >> hurt. And eventually all address spaces will be fine-grained. >> > I had thought only mmio is out of big lock's protection. While others > address space will take extra expense. So leave them until they are > ready to be out of big lock. The other address spaces are pio (which also needs fine-grained locking) and the dma address spaces (which are like address_space_memory, except they are accessed via DMA instead of from the vcpu). -- error compiling committee.c: too many arguments to function