From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTzQS-0005at-8N for qemu-devel@nongnu.org; Thu, 01 Nov 2012 14:23:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTzQR-00047z-1b for qemu-devel@nongnu.org; Thu, 01 Nov 2012 14:23:32 -0400 Received: from mout.web.de ([212.227.17.11]:49596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTzQQ-00047q-Nl for qemu-devel@nongnu.org; Thu, 01 Nov 2012 14:23:30 -0400 Message-ID: <5092BE1D.7000006@web.de> Date: Thu, 01 Nov 2012 19:23:25 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <5092A406.6030402@web.de> <5092AEB6.3020000@web.de> <5092AF93.3080703@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6C9612ED1A858E703F80BEF3" Subject: Re: [Qemu-devel] [PATCH] pc_sysfw: Always use alias for ISA BIOS region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6C9612ED1A858E703F80BEF3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-11-01 19:03, Jordan Justen wrote: > On Thu, Nov 1, 2012 at 10:21 AM, Jan Kiszka wrote: >> On 2012-11-01 18:17, Jan Kiszka wrote: >>> On 2012-11-01 18:15, Jordan Justen wrote: >>>> Would the old behavior need to be preserved for pc-1.1 & pc-1.2? >>> >>> Why? This is just restoring the older, correct behavior. >> >> Err, sorry, there was no difference to the behavior before pflash >> (unless flash was changed by the guest). >> >> Still, I see no point in preserving the current behavior even for comp= at >> machine. Which (sane) guest should rely on an inconsistency between th= e >> two BIOS mappings after an update? >=20 > I will not claim to know much about this, but I thought the purpose > was to allow qemu to properly restore old saved VMs. Ah, I'm getting the problem: the old version created additional RAM, outside the main memory, and that caused an additional vmsection to be written. Unfortunate. But I guess we can address this by registering a dummy vmstate for compat machine types. The content is redundant anyway. >=20 > I agree that the alias in an improvement in machine emulation, and I > don't think any guest software will rely upon the pc-1.1/pc-1.2 > behavior. >=20 > It is probably worth verifying that the 440 chipset PAM registers are > still working after this change. Seabios relies on PAM, so they are apparently still fine. More testing always welcome, of course. Jan --------------enig6C9612ED1A858E703F80BEF3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlCSviAACgkQitSsb3rl5xTmmwCfZhF1ceFic2yyLA27dV75MGYC JoYAnAnTpL5ArMnpikUMucgvge6D46PA =/M93 -----END PGP SIGNATURE----- --------------enig6C9612ED1A858E703F80BEF3--