From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU0m3-0000Ec-CD for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:49:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TU0m1-0003rm-I7 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:49:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU0m1-0003ri-97 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:49:53 -0400 Message-ID: <5092D21E.10406@redhat.com> Date: Thu, 01 Nov 2012 13:48:46 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig83B4EC0C8A3E2AE2D6A07386" Subject: Re: [Qemu-devel] [PATCH v3 24/35] postcopy outgoing: add -p option to migrate command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: benoit.hudzia@gmail.com, aarcange@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, stefanha@gmail.com, t.hirofuchi@aist.go.jp, dlaor@redhat.com, satoshi.itoh@aist.go.jp, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp, owasserm@redhat.com, avi@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig83B4EC0C8A3E2AE2D6A07386 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2012 02:33 AM, Isaku Yamahata wrote: > Added -p option to migrate command for postcopy mode and > introduce postcopy parameter for migration to indicate that postcopy mo= de > is enabled. >=20 > Signed-off-by: Isaku Yamahata > diff --git a/qapi-schema.json b/qapi-schema.json > index c615ee2..c969e5a 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2094,7 +2094,8 @@ > # Since: 0.14.0 > ## > { 'command': 'migrate', > - 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'b= ool' } } > + 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'b= ool' , > + '*postcopy': 'bool'} } You should also document this new variable a few lines earlier, something like: # @postcopy: #optional if true, perform a postcopy migration # (since 1.3, default false) Also, I have to wonder if this should go through migrate-set-capabilities rather than adding a new field to 'migrate'. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig83B4EC0C8A3E2AE2D6A07386 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQktIeAAoJEKeha0olJ0Nq+hcH/2Pid9Tbgf6RHkmoOWIExxSa m+rzEJni+Lt04xBoXR9be+D6q4rIbFSitn9xr/yX7AhPgnjCS+1+yhergeKFXsTD dMTco8A4eLZRodKR+MrfUwb080D5yDoVSITsFp1HDqQluicM0zG4YBLuSlfu4xdD aqPeDrXdti9VuTYVSGVV0cC+ELJCGPTp3NIy+/6iDsJwH1Ur8t7dgNI1UKmp7PEM Tlz34bSQtzdds0OZAC65qDbm8bPYQPLBDCZhiH1iHDlWmRl6wXyrzO4upgpqviKZ 1xLb954fTtcyF3+883C9fGI3cW1NgV66PHGiS0eq1AE/B08lWzR4J/9FQgupUSE= =KlsM -----END PGP SIGNATURE----- --------------enig83B4EC0C8A3E2AE2D6A07386--