From: Eric Blake <eblake@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: benoit.hudzia@gmail.com, aarcange@redhat.com,
aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com,
stefanha@gmail.com, t.hirofuchi@aist.go.jp, dlaor@redhat.com,
satoshi.itoh@aist.go.jp, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp,
owasserm@redhat.com, avi@redhat.com, pbonzini@redhat.com,
chegu_vinod@hp.com
Subject: Re: [Qemu-devel] [PATCH v3 26/35] postcopy/outgoing: add -n options to disable background transfer
Date: Thu, 01 Nov 2012 13:56:55 -0600 [thread overview]
Message-ID: <5092D407.6030403@redhat.com> (raw)
In-Reply-To: <4fd94b3687851cb5cce5de39167192d3a709c5b3.1351582535.git.yamahata@valinux.co.jp>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On 10/30/2012 02:33 AM, Isaku Yamahata wrote:
> This is for benchmark purpose
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> +++ b/qapi-schema.json
> @@ -2095,7 +2095,7 @@
> ##
> { 'command': 'migrate',
> 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' ,
> - '*postcopy': 'bool'} }
> + '*postcopy': 'bool', '*nobg': 'bool'} }
Again, document this option above, and mention that it was introduced in
1.3. In QMP, we prefer easier-to-read strings, I would consider naming
it 'background' with a default of true, where you pass false to get the
new behavior, instead of 'nobg' with a default of false and causing
double-negative logic.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-11-01 19:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 8:32 [Qemu-devel] [PATCH v3 00/35] postcopy live migration Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 01/35] migration.c: remove redundant line in migrate_init() Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 02/35] arch_init: DPRINTF format error and typo Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 03/35] split MRU ram list Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 04/35] add a version number to ram_list Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 05/35] protect the ramlist with a separate mutex Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 06/35] osdep: add qemu_read_full() to read interrupt-safely Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 07/35] savevm: export qemu_peek_buffer, qemu_peek_byte, qemu_file_skip, qemu_fflush Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 08/35] savevm/QEMUFile: consolidate QEMUFile functions a bit Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 09/35] savevm/QEMUFile: introduce qemu_fopen_fd Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 10/35] savevm/QEMUFile: add read/write QEMUFile on memory buffer Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 11/35] savevm, buffered_file: introduce method to drain buffer of buffered file Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 12/35] arch_init: export RAM_SAVE_xxx flags for postcopy Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 13/35] arch_init/ram_save: introduce constant for ram save version = 4 Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 14/35] arch_init: refactor ram_save_block() and export ram_save_block() Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 15/35] arch_init/ram_save_setup: factor out bitmap alloc/free Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 16/35] arch_init/ram_load: refactor ram_load Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 17/35] arch_init: factor out logic to find ram block with id string Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 18/35] migration: export migrate_fd_completed() and migrate_fd_cleanup() Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 19/35] uvmem.h: import Linux uvmem.h and teach update-linux-headers.sh Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 20/35] osdep: add QEMU_MADV_REMOVE and tirivial fix Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 21/35] postcopy: introduce helper functions for postcopy Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 22/35] savevm: add new section that is used by postcopy Isaku Yamahata
2012-10-30 8:32 ` [Qemu-devel] [PATCH v3 23/35] postcopy: implement incoming part of postcopy live migration Isaku Yamahata
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 24/35] postcopy outgoing: add -p option to migrate command Isaku Yamahata
2012-11-01 19:48 ` Eric Blake
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 25/35] postcopy: implement outgoing part of postcopy live migration Isaku Yamahata
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 26/35] postcopy/outgoing: add -n options to disable background transfer Isaku Yamahata
2012-11-01 19:56 ` Eric Blake [this message]
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 27/35] postcopy/outgoing: implement forward/backword prefault Isaku Yamahata
2012-11-01 20:10 ` Eric Blake
2012-11-02 5:24 ` Isaku Yamahata
2012-11-02 15:22 ` Eric Blake
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 28/35] arch_init: factor out setting last_block, last_offset Isaku Yamahata
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 29/35] postcopy/outgoing: add movebg mode(-m) to migration command Isaku Yamahata
2012-11-01 20:15 ` Eric Blake
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 30/35] arch_init: factor out ram_load Isaku Yamahata
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 31/35] arch_init: export ram_save_iterate() Isaku Yamahata
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 32/35] postcopy: pre+post optimization incoming side Isaku Yamahata
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 33/35] arch_init: export migration_bitmap_sync and helper method to get bitmap Isaku Yamahata
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 34/35] postcopy/outgoing: introduce precopy_count parameter Isaku Yamahata
2012-11-01 21:20 ` Eric Blake
2012-10-30 8:33 ` [Qemu-devel] [PATCH v3 35/35] postcopy: pre+post optimization outgoing side Isaku Yamahata
2012-10-30 18:53 ` [Qemu-devel] [PATCH v3 00/35] postcopy live migration Benoit Hudzia
2012-10-31 3:25 ` Isaku Yamahata
2012-10-30 18:55 ` Benoit Hudzia
2012-11-06 11:04 ` Orit Wasserman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5092D407.6030403@redhat.com \
--to=eblake@redhat.com \
--cc=aarcange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=benoit.hudzia@gmail.com \
--cc=chegu_vinod@hp.com \
--cc=dlaor@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=satoshi.itoh@aist.go.jp \
--cc=stefanha@gmail.com \
--cc=t.hirofuchi@aist.go.jp \
--cc=yamahata@valinux.co.jp \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).