From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU0tU-000415-K1 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TU0tT-0006CH-9K for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:57:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU0tS-0006C0-WF for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:57:35 -0400 Message-ID: <5092D407.6030403@redhat.com> Date: Thu, 01 Nov 2012 13:56:55 -0600 From: Eric Blake MIME-Version: 1.0 References: <4fd94b3687851cb5cce5de39167192d3a709c5b3.1351582535.git.yamahata@valinux.co.jp> In-Reply-To: <4fd94b3687851cb5cce5de39167192d3a709c5b3.1351582535.git.yamahata@valinux.co.jp> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig78088BD1E0C5AEC10000CF2F" Subject: Re: [Qemu-devel] [PATCH v3 26/35] postcopy/outgoing: add -n options to disable background transfer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: benoit.hudzia@gmail.com, aarcange@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, stefanha@gmail.com, t.hirofuchi@aist.go.jp, dlaor@redhat.com, satoshi.itoh@aist.go.jp, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp, owasserm@redhat.com, avi@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig78088BD1E0C5AEC10000CF2F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2012 02:33 AM, Isaku Yamahata wrote: > This is for benchmark purpose >=20 > Signed-off-by: Isaku Yamahata > +++ b/qapi-schema.json > @@ -2095,7 +2095,7 @@ > ## > { 'command': 'migrate', > 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'b= ool' , > - '*postcopy': 'bool'} } > + '*postcopy': 'bool', '*nobg': 'bool'} } Again, document this option above, and mention that it was introduced in 1.3. In QMP, we prefer easier-to-read strings, I would consider naming it 'background' with a default of true, where you pass false to get the new behavior, instead of 'nobg' with a default of false and causing double-negative logic. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig78088BD1E0C5AEC10000CF2F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQktQHAAoJEKeha0olJ0NqnyEIAKaWX/cmDR4xr80KjRAytMDS dNdq+eMGJJ6sYWnCZgaMEuDvdPhKscKes3fGLwYAVSqMhVkvP/5KT/oIwrA1i50l ch4vp6ty11MH7FNGWaYssf8u6ISqg1IGOL4ydlGWTZWwuxsImO/x8opKozh9YGSC DFB2uuVlnHILlO+IL+A+n63nAZSt5SJo3BQ+B1UiqWX6zBAuxXgwfQ57gLM3rpBk WajA0wzVnlWTirIjlrAwqxH0cwRHOasuJSCO0v6pIwr4Q599mfjnGKH8EYXAN0pr 9+MbS/2hhwTRqByoIUgDj/vhPoLj98aHC5WbEP+0p4pb+bgl5d0wnpWX9PnLe2c= =6Lfb -----END PGP SIGNATURE----- --------------enig78088BD1E0C5AEC10000CF2F--