From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU1Br-0004Ue-H3 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 16:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TU1Bp-0003Ve-Vw for qemu-devel@nongnu.org; Thu, 01 Nov 2012 16:16:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU1Bp-0003VM-Nr for qemu-devel@nongnu.org; Thu, 01 Nov 2012 16:16:33 -0400 Message-ID: <5092D745.1030606@redhat.com> Date: Thu, 01 Nov 2012 14:10:45 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3F05B14651859D6B4214C779" Subject: Re: [Qemu-devel] [PATCH v3 27/35] postcopy/outgoing: implement forward/backword prefault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: benoit.hudzia@gmail.com, aarcange@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, stefanha@gmail.com, t.hirofuchi@aist.go.jp, dlaor@redhat.com, satoshi.itoh@aist.go.jp, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp, owasserm@redhat.com, avi@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3F05B14651859D6B4214C779 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2012 02:33 AM, Isaku Yamahata wrote: > When page is requested, send surrounding pages are also sent. >=20 > Signed-off-by: Isaku Yamahata > --- > hmp-commands.hx | 15 ++++++++----- > hmp.c | 3 +++ > migration-postcopy.c | 57 ++++++++++++++++++++++++++++++++++++++++++= +++----- > migration.c | 20 ++++++++++++++++++ > migration.h | 2 ++ > qapi-schema.json | 3 ++- > 6 files changed, 89 insertions(+), 11 deletions(-) >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > index b054760..5e2c77c 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -826,26 +826,31 @@ ETEXI > =20 > { > .name =3D "migrate", > - .args_type =3D "detach:-d,blk:-b,inc:-i,postcopy:-p,nobg:-n,u= ri:s", > - .params =3D "[-d] [-b] [-i] [-p [-n]] uri", > + .args_type =3D "detach:-d,blk:-b,inc:-i,postcopy:-p,nobg:-n,u= ri:s," > + "forward:i?,backward:i?", > + .params =3D "[-d] [-b] [-i] [-p [-n] uri [forward] [backwo= rd]", I don't care what we do to the 'migrate' HMP command, but for QMP... > +++ b/qapi-schema.json > @@ -2095,7 +2095,8 @@ > ## > { 'command': 'migrate', > 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'b= ool' , > - '*postcopy': 'bool', '*nobg': 'bool'} } > + '*postcopy': 'bool', '*nobg': 'bool', > + '*forward': 'int', '*backward': 'int'} } Do we really want to be adding new options to migrate (and if so, where's the documentation), or do we need a new monitor command similar to migrate-set-capabilities or migrate-set-cache-size? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig3F05B14651859D6B4214C779 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQktdFAAoJEKeha0olJ0NqNMEH/1A6csS+/6OS7G+7sLK2Bot+ U+rXFiy4QiIneZ/eLTN/S174Nbhk9hmFNgFz11p4aiuDbazSliErJBn5WLM0fEer DJfzwEWJtcukm8Pfz2rLhJ0MLZwP85MiyLA5Fqau7NHHQXvTjJ98SS50n6xR5Dn4 B3x4+taoqrYF/Zo3GNRPD6q7iZy3j5k5fbJsEnN13ijjNQ6te153nmuEaBUXw/gS rL/kFBrv4ifScwQOA9WJUVREWDFoqYnuimdcQ59n3W8LsrsYDpKeCEiXDLE/6nLt 4yiuWjw61ODq5tJ5xhMiZ/Zn40sDM7+pZVZcmxHKYzEjAAsRiPM6xJY6IxrN6ps= =zPRJ -----END PGP SIGNATURE----- --------------enig3F05B14651859D6B4214C779--