From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU2DO-00014B-7C for qemu-devel@nongnu.org; Thu, 01 Nov 2012 17:22:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TU2DN-0006XI-0p for qemu-devel@nongnu.org; Thu, 01 Nov 2012 17:22:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU2DM-0006X0-Nz for qemu-devel@nongnu.org; Thu, 01 Nov 2012 17:22:12 -0400 Message-ID: <5092E7FF.2070207@redhat.com> Date: Thu, 01 Nov 2012 15:22:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1351803990-12983-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1351803990-12983-1-git-send-email-aliguori@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig292B969D8F3DEB8BCEA759DE" Subject: Re: [Qemu-devel] [PATCH] Fix build error in virtfs-proxy-helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Gerhard Wiesinger , "M. Mohan Kumar" , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig292B969D8F3DEB8BCEA759DE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/01/2012 03:06 PM, Anthony Liguori wrote: > I don't have a kernel with the necessary syscalls so this is completely= > untested. >=20 > Cc: "M. Mohan Kumar" > Cc: Gerhard Wiesinger > Reported-by: Gerhard Wiesinger > Signed-off-by: Anthony Liguori > --- > fsdev/virtfs-proxy-helper.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c > index f9a8270..bc50e3e3 100644 > --- a/fsdev/virtfs-proxy-helper.c > +++ b/fsdev/virtfs-proxy-helper.c > @@ -286,12 +286,16 @@ static int setfsugid(int uid, int gid) > * We still need DAC_OVERRIDE because we don't change > * supplementary group ids, and hence may be subjected DAC rules > */ > + int ret; > cap_value_t cap_list[] =3D { > CAP_DAC_OVERRIDE, > }; > =20 > - setfsgid(gid); > - setfsuid(uid); > + ret =3D setfsgid(gid); > + g_assert(ret !=3D -1); This has been reported several times now, with several different patches proposed. Can we get consensus on which one to use? https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02013.html --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig292B969D8F3DEB8BCEA759DE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQkuf/AAoJEKeha0olJ0NqG0AH/jA8JK89fbzl2+aTOo5vA24N JCvOWRAUofO8/UIgHtj7+AqimpQkJY6n+PdOMcEusC/vNU3JXLXi1x26dR9VHPk6 6TZuTPUhM+dZvCHXtsrNAwydDab62NTi1PFW4RMff9fWXvP3ohiEivpR2SEC4HOL hraxcqz7LJ9Rb5LQA7Qzzz1m2yQPZskE05U7jGx68wsViqBQ+OQFBR9ReKtR5YXe botK6gcil3aQJSvUvYHtnamVlme1Lu/6sKhzPZswqQzedmC9OuBJ9i+G7qP32azf +xddMq8yWXbvDXmLXHDgGYM9ScYD3AeflZawAPJWz/urkTyKPagmms2U0azUDMY= =lnPR -----END PGP SIGNATURE----- --------------enig292B969D8F3DEB8BCEA759DE--