From: Lei Li <lilei@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] net: avoid segfault in case netdev_del non-host network device
Date: Fri, 02 Nov 2012 10:10:19 +0800 [thread overview]
Message-ID: <50932B8B.6070802@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJSP0QV18GB28wp5RkvgcvVPcaOKFyRqtoiRCAEwftKOJ7ywjA@mail.gmail.com>
On 11/01/2012 05:42 PM, Stefan Hajnoczi wrote:
> On Thu, Nov 1, 2012 at 8:48 AM, Lei Li <lilei@linux.vnet.ibm.com> wrote:
>> netdev_del assume that remove host network device.
>> However, when try to remove a non-host network device
>> by netdev_del, it will cause a segfault.
> I recently sent a similar fix which forbids deleting non-netdev net
> clients from netdev_del:
> http://patchwork.ozlabs.org/patch/193759/
Hi Stefan,
Sorry I did not see it... Seems I miss this chance to submit a patch. :-P
BTW, I was thinking that should we add another hacking to check
if the deleting object is a netdev or a VLAN client?
>
> netdev_del should only be used on -netdev/netdev_add devices.
> Therefore my patch raises an error before we call
> qemu_del_net_client(nc).
>
> Stefan
>
--
Lei
next prev parent reply other threads:[~2012-11-02 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 7:48 [Qemu-devel] [PATCH] net: avoid segfault in case netdev_del non-host network device Lei Li
2012-11-01 9:42 ` Stefan Hajnoczi
2012-11-02 2:10 ` Lei Li [this message]
2012-11-02 7:38 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50932B8B.6070802@linux.vnet.ibm.com \
--to=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).