From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUI5L-0005LX-So for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:19:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUI5K-00069M-Af for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:18:59 -0400 Received: from mail.profihost.ag ([85.158.179.208]:43711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUI5J-00064u-WF for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:18:58 -0400 Message-ID: <5093D645.8070906@profihost.ag> Date: Fri, 02 Nov 2012 15:18:45 +0100 From: Stefan Priebe - Profihost AG MIME-Version: 1.0 References: <509306CC.5080307@profihost.ag> <5093078C.4020404@inktank.com> <50938233.9090902@profihost.ag> <50938DA0.6090205@profihost.ag> In-Reply-To: <50938DA0.6090205@profihost.ag> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] RBD trim / unmap support? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Josh Durgin Cc: "ceph-devel@vger.kernel.org" , qemu-devel Hello qemu list, i cc you as i'm not sure where the problem is. When i use scsi-hd with discard_granularity the discard works fine on target size but the client print these - immediatly after sending discard / trim commands with mkfs.btrfs. > [ 75.076895] sd 2:0:0:4: [sdc] > [ 75.078353] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.079377] sd 2:0:0:4: [sdc] > [ 75.080410] Sense Key : Aborted Command [current] > [ 75.081446] sd 2:0:0:4: [sdc] > [ 75.082459] Add. Sense: I/O process terminated > [ 75.083466] sd 2:0:0:4: [sdc] CDB: > [ 75.084473] Write same(16): 93 08 00 00 00 00 00 00 00 00 00 7f ff ff > 00 00 > [ 75.085535] end_request: I/O error, dev sdc, sector 0 > [ 75.086567] sd 2:0:0:4: [sdc] > [ 75.087569] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.088605] sd 2:0:0:4: [sdc] > [ 75.089610] Sense Key : Aborted Command [current] > [ 75.090630] sd 2:0:0:4: [sdc] > [ 75.091631] Add. Sense: I/O process terminated > [ 75.092621] sd 2:0:0:4: [sdc] CDB: > [ 75.093579] Write same(16): 93 08 00 00 00 00 00 7f ff ff 00 7f ff ff > 00 00 > [ 75.094581] end_request: I/O error, dev sdc, sector 8388607 > [ 75.095558] sd 2:0:0:4: [sdc] > [ 75.096561] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.097553] sd 2:0:0:4: [sdc] > [ 75.098520] Sense Key : Aborted Command [current] > [ 75.099484] sd 2:0:0:4: [sdc] > [ 75.100471] Add. Sense: I/O process terminated > [ 75.101439] sd 2:0:0:4: [sdc] CDB: > [ 75.102432] Write same(16): 93 08 00 00 00 00 00 ff ff fe 00 7f ff ff > 00 00 > [ 75.103464] end_request: I/O error, dev sdc, sector 16777214 > [ 75.104503] sd 2:0:0:4: [sdc] > [ 75.105507] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.106514] sd 2:0:0:4: [sdc] > [ 75.107525] Sense Key : Aborted Command [current] > [ 75.108545] sd 2:0:0:4: [sdc] > [ 75.109525] Add. Sense: I/O process terminated > [ 75.110487] sd 2:0:0:4: [sdc] CDB: > [ 75.111418] Write same(16): 93 08 00 00 00 00 01 7f ff fd 00 7f ff ff > 00 00 > [ 75.112419] end_request: I/O error, dev sdc, sector 25165821 > [ 75.238627] sd 2:0:0:4: [sdc] > [ 75.239946] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.241197] sd 2:0:0:4: [sdc] > [ 75.242097] Sense Key : Aborted Command [current] > [ 75.242627] sd 2:0:0:4: [sdc] > [ 75.242627] Add. Sense: I/O process terminated > [ 75.242627] sd 2:0:0:4: [sdc] CDB: > [ 75.242627] Write same(16): 93 08 00 00 00 00 01 ff ff fc 00 7f ff ff > 00 00 > [ 75.242627] end_request: I/O error, dev sdc, sector 33554428 > [ 75.447311] sd 2:0:0:4: [sdc] > [ 75.448505] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.449392] sd 2:0:0:4: [sdc] > [ 75.450262] Sense Key : Aborted Command [current] > [ 75.451134] sd 2:0:0:4: [sdc] > [ 75.451312] Add. Sense: I/O process terminated > [ 75.451312] sd 2:0:0:4: [sdc] CDB: > [ 75.451312] Write same(16): 93 08 00 00 00 00 02 7f ff fb 00 7f ff ff > 00 00 > [ 75.451312] end_request: I/O error, dev sdc, sector 41943035 > [ 75.476364] sd 2:0:0:4: [sdc] > [ 75.477252] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.478135] sd 2:0:0:4: [sdc] > [ 75.479004] Sense Key : Aborted Command [current] > [ 75.479891] sd 2:0:0:4: [sdc] > [ 75.480358] Add. Sense: I/O process terminated > [ 75.480358] sd 2:0:0:4: [sdc] CDB: > [ 75.480358] Write same(16): 93 08 00 00 00 00 02 ff ff fa 00 7f ff ff > 00 00 > [ 75.480358] end_request: I/O error, dev sdc, sector 50331642 > [ 75.496374] sd 2:0:0:4: [sdc] > [ 75.497202] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 75.498077] sd 2:0:0:4: [sdc] > [ 75.498948] Sense Key : Aborted Command [current] > [ 75.499818] sd 2:0:0:4: [sdc] > [ 75.500374] Add. Sense: I/O process terminated > [ 75.500374] sd 2:0:0:4: [sdc] CDB: > [ 75.500374] Write same(16): 93 08 00 00 00 00 03 7f ff f9 00 7f ff ff > 00 00 > [ 75.500374] end_request: I/O error, dev sdc, sector 58720249 > > Stefan > > Am 02.11.2012 09:20, schrieb Stefan Priebe - Profihost AG: >> Am 02.11.2012 00:36, schrieb Josh Durgin: >>> On 11/01/2012 04:33 PM, Stefan Priebe wrote: >>>> Hello list, >>>> >>>> does rbd support trim / unmap? Or is it planned to support it? >>>> >>>> Greets, >>>> Stefan >>> >>> librbd (and thus qemu) support it. The rbd kernel module does not yet. >>> See http://ceph.com/docs/master/rbd/qemu-rbd/#enabling-discard-trim >> >> Thanks! Is there any recommanded value for discard_granularity? With >> fstrim and iscsi i use 128kb. >> >> Stefan