From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t
Date: Fri, 02 Nov 2012 15:49:24 +0100 [thread overview]
Message-ID: <5093DD74.2080807@redhat.com> (raw)
In-Reply-To: <1351697677-31598-2-git-send-email-stefanha@redhat.com>
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto:
> Using appropriate types for variables is a good thing :). All users
> simply do sizeof(MyType) and the value is passed to a memory allocator,
> it should be size_t.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-aio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-aio.h b/qemu-aio.h
> index 1b7eb6e..111b0b3 100644
> --- a/qemu-aio.h
> +++ b/qemu-aio.h
> @@ -23,7 +23,7 @@ typedef void BlockDriverCompletionFunc(void *opaque, int ret);
>
> typedef struct AIOPool {
> void (*cancel)(BlockDriverAIOCB *acb);
> - int aiocb_size;
> + size_t aiocb_size;
> BlockDriverAIOCB *free_aiocb;
> } AIOPool;
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2012-11-02 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 15:34 [Qemu-devel] [PATCH v2 0/3] aio: use g_slice_alloc() for AIOCB pooling Stefan Hajnoczi
2012-10-31 15:34 ` [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t Stefan Hajnoczi
2012-11-02 14:49 ` Paolo Bonzini [this message]
2012-10-31 15:34 ` [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling Stefan Hajnoczi
2012-11-02 14:49 ` Paolo Bonzini
2012-11-12 10:34 ` Kevin Wolf
2012-11-12 10:37 ` Paolo Bonzini
2012-11-12 10:42 ` Kevin Wolf
2012-10-31 15:34 ` [Qemu-devel] [PATCH v2 3/3] aio: rename AIOPool to AIOCBInfo Stefan Hajnoczi
2012-11-02 14:50 ` Paolo Bonzini
2012-11-12 10:34 ` [Qemu-devel] [PATCH v2 0/3] aio: use g_slice_alloc() for AIOCB pooling Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093DD74.2080807@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).