From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TUIYs-0007YO-Bt
	for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:49:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TUIYr-0007dR-7S
	for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:49:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49294)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TUIYq-0007dJ-VV
	for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:49:29 -0400
Message-ID: <5093DD74.2080807@redhat.com>
Date: Fri, 02 Nov 2012 15:49:24 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1351697677-31598-1-git-send-email-stefanha@redhat.com>
	<1351697677-31598-2-git-send-email-stefanha@redhat.com>
In-Reply-To: <1351697677-31598-2-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int ->
	size_t
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto:
> Using appropriate types for variables is a good thing :).  All users
> simply do sizeof(MyType) and the value is passed to a memory allocator,
> it should be size_t.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  qemu-aio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-aio.h b/qemu-aio.h
> index 1b7eb6e..111b0b3 100644
> --- a/qemu-aio.h
> +++ b/qemu-aio.h
> @@ -23,7 +23,7 @@ typedef void BlockDriverCompletionFunc(void *opaque, int ret);
>  
>  typedef struct AIOPool {
>      void (*cancel)(BlockDriverAIOCB *acb);
> -    int aiocb_size;
> +    size_t aiocb_size;
>      BlockDriverAIOCB *free_aiocb;
>  } AIOPool;
>  
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>