From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUIcz-0002b9-0V for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:53:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUIcu-0000jj-9S for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:53:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUIcu-0000jd-0u for qemu-devel@nongnu.org; Fri, 02 Nov 2012 10:53:40 -0400 Message-ID: <5093DE70.6030007@redhat.com> Date: Fri, 02 Nov 2012 15:53:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1351599394-24876-1-git-send-email-pbonzini@redhat.com> <1351599394-24876-4-git-send-email-pbonzini@redhat.com> <508FCA33.5030309@redhat.com> <508FE140.2000302@redhat.com> <50901AAE.4010802@web.de> In-Reply-To: <50901AAE.4010802@web.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: mtosatti@redhat.com, Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org Il 30/10/2012 19:21, Jan Kiszka ha scritto: > > > Aren't we still dependent on the order of processing? If the APIC is > > > restored after the device, won't we get the same problem? > > > > Strictly speaking yes, but CPUs and APICs are always the first devices > > to be saved. > Hmm, thinking about this again: Why is the MSI event injected at all > during restore, specifically while the device models are in transitional > state. Can you explain this? Because the (virtio-serial) port was connected on the source and disconnected on the destination, or vice versa. In my simplified reproducer, I'm really using different command-lines on the source and destination, but it is not necessary. For example, if you have a socket backend, the destination will usually be disconnected at the time the machine loads. One alternative fix is a vm_clock timer that expires immediately. It would fix both MSI and INTx, on the other hand I thought it was an APIC bug because the QEMU APIC works nicely. > Does the same pattern then also apply on INTx injection? Yes. Paolo