From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUJ5C-0004J0-6s for qemu-devel@nongnu.org; Fri, 02 Nov 2012 11:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUJ57-0001sK-6I for qemu-devel@nongnu.org; Fri, 02 Nov 2012 11:22:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUJ56-0001sA-Tr for qemu-devel@nongnu.org; Fri, 02 Nov 2012 11:22:49 -0400 Message-ID: <5093E521.6020802@redhat.com> Date: Fri, 02 Nov 2012 09:22:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <5092D745.1030606@redhat.com> <20121102052434.GH22180@valinux.co.jp> In-Reply-To: <20121102052434.GH22180@valinux.co.jp> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4AF7194CAA7AA7738B2FF6F1" Subject: Re: [Qemu-devel] [PATCH v3 27/35] postcopy/outgoing: implement forward/backword prefault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: benoit.hudzia@gmail.com, aarcange@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, stefanha@gmail.com, t.hirofuchi@aist.go.jp, dlaor@redhat.com, satoshi.itoh@aist.go.jp, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp, owasserm@redhat.com, avi@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4AF7194CAA7AA7738B2FF6F1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 11/01/2012 11:24 PM, Isaku Yamahata wrote: >>> +++ b/qapi-schema.json >>> @@ -2095,7 +2095,8 @@ >>> ## >>> { 'command': 'migrate', >>> 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': = 'bool' , >>> - '*postcopy': 'bool', '*nobg': 'bool'} } >>> + '*postcopy': 'bool', '*nobg': 'bool', >>> + '*forward': 'int', '*backward': 'int'} } >> >> Do we really want to be adding new options to migrate (and if so, >> where's the documentation), or do we need a new monitor command simila= r >> to migrate-set-capabilities or migrate-set-cache-size? >=20 > Okay, migrate-set-capabilities seems usable for boolean and scalable > for future extension. > On the other hand, migrate-set-cache-size takes only single integer > as arguments. So it doesn't seem usable without modification. > How about this? >=20 > { 'type': 'MigrationParameters', > 'data': {'parameter': 'name': 'str', 'value': 'int' } } More like: { 'enum': 'MigrationParameterName', 'data': ['ParameterName'... ] } { 'type': 'MigrationParameter', 'data': {'parameter': 'MigrationParameterName', 'value': 'int' } } >=20 > { 'command': 'migrate-set-parameters', > 'data': { 'parameters' ['MigrationParameters']}} Yes, this seems more extensible. >=20 >=20 > { 'command': 'query-migrate-parameters', > 'returns': [['MigrationParameters']]} One layer too many of [], but yes, this also seems reasonable. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4AF7194CAA7AA7738B2FF6F1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQk+UiAAoJEKeha0olJ0NqEUoH/jsGKg4DpnW6muPdUXV+n9eu 2YNeEOKr0pfBGUG1SxaaZsEL6ctP2MMVuq9jFUtAvQSjGMPS9vi9JWaGEqb4dw6F X5qQNqqP4TpvqCOjhiud9JHnQgt5o7JKqOcMHJYt+VgjOdFDCbCwejWkenh2QDIF aJ5vRAXGN/m97nNIVZ4HfyB00hUBzS9RuQrtzGXEA171AGSubn6iVgx6VuzioLby SE9n/1Y/qaEzE+rGlILr7vEUbyAuNtr01m/zw5W0HWBv18qMUFh0yy7DxTL1rLhQ jAroU3K0F6S8TZ8OFX+vLcqysDBj9LYOzxdwMHDa5W0m21+KUvlr8V0lOylI+0I= =eQf7 -----END PGP SIGNATURE----- --------------enig4AF7194CAA7AA7738B2FF6F1--