From: Gerd Hoffmann <kraxel@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix out-of-tree and cross compile builds for pixman
Date: Wed, 07 Nov 2012 12:43:21 +0100 [thread overview]
Message-ID: <509A4959.5030802@redhat.com> (raw)
In-Reply-To: <CAAu8pHuMNwq7TGtyHu5UJ3CXBZ3taONdaK2yQ2JjqWG3d10_RQ@mail.gmail.com>
On 11/03/12 21:15, Blue Swirl wrote:
> On Sat, Nov 3, 2012 at 7:02 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 3 November 2012 19:47, Blue Swirl <blauwirbel@gmail.com> wrote:
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -122,7 +122,7 @@ subdir-pixman: pixman/Makefile
>>> $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pixman V="$(V)" all,)
>>>
>>> pixman/Makefile: $(SRC_PATH)/pixman/configure
>>> - (cd pixman; $(SRC_PATH)/pixman/configure --disable-shared --enable-static)
>>> + (cd pixman; CC=$(CC) LD=$(LD) AR=$(AR) NM=$(NM) RANLIB=$(RANLIB) $(SRC_PATH)/pixman/configure --disable-shared --enable-static)
>>
>> Not tested, but aren't there quoting issues here if you're
>> building with --cc='ccache gcc' ?
>
> Yes. Also configure fails because the variables are not expanded and
> directory pixman/pixman does not exist. Funny how it worked earlier.
Turned out part of the issue is that having pixman-devel installed
masked some of the build issues of the internal pixman even when
building --without-pixman-system, so my build testing was incomplete.
Pushed test branch:
git://git.kraxel.org/qemu rebase/pixman
Dependency issue isn't tackled yet, but non-parallel builds are working
fine for me. Feedback is welcome.
cheers,
Gerd
next prev parent reply other threads:[~2012-11-07 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 18:47 [Qemu-devel] [PATCH] Fix out-of-tree and cross compile builds for pixman Blue Swirl
2012-11-03 19:02 ` Peter Maydell
2012-11-03 20:15 ` Blue Swirl
2012-11-04 12:10 ` Stefan Weil
2012-11-07 2:33 ` Johnson, Eric
2012-11-07 11:47 ` Gerd Hoffmann
2012-11-17 9:56 ` Stefan Weil
2012-11-07 11:43 ` Gerd Hoffmann [this message]
2012-11-07 20:06 ` Johnson, Eric
2012-11-07 20:57 ` Johnson, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509A4959.5030802@redhat.com \
--to=kraxel@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).