From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TW42b-0002iS-7d
	for qemu-devel@nongnu.org; Wed, 07 Nov 2012 06:43:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TW42a-00049Y-6M
	for qemu-devel@nongnu.org; Wed, 07 Nov 2012 06:43:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54328)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TW42Z-00049R-Sw
	for qemu-devel@nongnu.org; Wed, 07 Nov 2012 06:43:28 -0500
Message-ID: <509A4959.5030802@redhat.com>
Date: Wed, 07 Nov 2012 12:43:21 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <2927d80bed65c6e77cab02c82eaf92e50c454b68.1351968408.git.blauwirbel@gmail.com>
	<CAFEAcA_TqcdXSToh10xhy1=i86JiaseyBL8pZ2FAMVXVREgBsg@mail.gmail.com>
	<CAAu8pHuMNwq7TGtyHu5UJ3CXBZ3taONdaK2yQ2JjqWG3d10_RQ@mail.gmail.com>
In-Reply-To: <CAAu8pHuMNwq7TGtyHu5UJ3CXBZ3taONdaK2yQ2JjqWG3d10_RQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Fix out-of-tree and cross compile builds
 for pixman
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On 11/03/12 21:15, Blue Swirl wrote:
> On Sat, Nov 3, 2012 at 7:02 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 3 November 2012 19:47, Blue Swirl <blauwirbel@gmail.com> wrote:
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -122,7 +122,7 @@ subdir-pixman: pixman/Makefile
>>>         $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pixman V="$(V)" all,)
>>>
>>>  pixman/Makefile: $(SRC_PATH)/pixman/configure
>>> -       (cd pixman; $(SRC_PATH)/pixman/configure --disable-shared --enable-static)
>>> +       (cd pixman; CC=$(CC) LD=$(LD) AR=$(AR) NM=$(NM) RANLIB=$(RANLIB) $(SRC_PATH)/pixman/configure --disable-shared --enable-static)
>>
>> Not tested, but aren't there quoting issues here if you're
>> building with --cc='ccache gcc' ?
> 
> Yes. Also configure fails because the variables are not expanded and
> directory pixman/pixman does not exist. Funny how it worked earlier.

Turned out part of the issue is that having pixman-devel installed
masked some of the build issues of the internal pixman even when
building --without-pixman-system, so my build testing was incomplete.

Pushed test branch:
  git://git.kraxel.org/qemu rebase/pixman

Dependency issue isn't tackled yet, but non-parallel builds are working
fine for me.  Feedback is welcome.

cheers,
  Gerd