From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWZK9-0000Tf-Ak for qemu-devel@nongnu.org; Thu, 08 Nov 2012 16:07:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TWZK7-0004zq-3q for qemu-devel@nongnu.org; Thu, 08 Nov 2012 16:07:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWZK6-0004zZ-SJ for qemu-devel@nongnu.org; Thu, 08 Nov 2012 16:07:39 -0500 Message-ID: <509C1F16.2090808@redhat.com> Date: Thu, 08 Nov 2012 22:07:34 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Gerhard Wiesinger , Anthony Liguori , qemu-devel@nongnu.org Hi, > I think this is fixing this at the wrong level. Either we > should require that drivers (in this case vmware_vga.c) > must not call dpy_gfx_update() with out of range values, > or we should do the clipping in the console.c layer, but > I don't think requiring every UI backend to clip is the > right thing. Anthony? Agree. IMHO vmware_vga.c is at fault here and should be fixed. We can add some asserts to console.[ch] to enforce this ... cheers, Gerd