From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWpBu-0005Vx-57 for qemu-devel@nongnu.org; Fri, 09 Nov 2012 09:04:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TWpBs-0005vo-Pe for qemu-devel@nongnu.org; Fri, 09 Nov 2012 09:04:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWpBs-0005u9-C3 for qemu-devel@nongnu.org; Fri, 09 Nov 2012 09:04:12 -0500 Message-ID: <509D059F.9000809@redhat.com> Date: Fri, 09 Nov 2012 14:31:11 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <509C1F16.2090808@redhat.com> <509CAD36.1070800@wiesinger.com> <87pq3n864r.fsf@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Gerhard Wiesinger , Anthony Liguori , qemu-devel@nongnu.org On 11/09/12 10:50, Peter Maydell wrote: > On 9 November 2012 10:42, Anthony Liguori wrote: >> While the abstract discussion is fun, it never hurts to be defensive. I >> agree the root cause is vmware-vga but checking in vnc doesn't hurt. > > Defensive programming would suggest doing the clipping in the > console.c layer. That sounds a reasonable plan to me (especially > if we've hit similar problems multiple times in the past). Fully agree, I'll cook up a patch as I'm touching that anyway. Question is just whenever we'll go silently fixup stuff in console.c or use assert()s to enforce callers getting this correct. I'd tend to use assert() as vmware-vga passing bogous stuff there IMHO indicates there is a bug in vmware-vga. cheers, Gerd