From: "Andreas Färber" <afaerber@suse.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Zhouyi Zhou <yizhouzhou@ict.ac.cn>,
Bruce Rogers <brogers@suse.com>, Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset
Date: Fri, 09 Nov 2012 18:21:15 +0100 [thread overview]
Message-ID: <509D3B8B.8050900@suse.de> (raw)
In-Reply-To: <507BD3D1.3010804@redhat.com>
Am 15.10.2012 11:13, schrieb Kevin Wolf:
> What I'm suggesting (not even compile tested!) is:
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 48e1b95..d665675 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -388,10 +388,7 @@ typedef struct QCowAIOCB {
>
> static void qcow2_aio_cancel(BlockDriverAIOCB *blockacb)
> {
> - QCowAIOCB *acb = container_of(blockacb, QCowAIOCB, common);
> - if (acb->hd_aiocb)
> - bdrv_aio_cancel(acb->hd_aiocb);
> - qemu_aio_release(acb);
> + qemu_aio_flush();
> }
>
> static AIOPool qcow2_aio_pool = {
Thanks, we've applied this to stable-0.15.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-11-09 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 8:03 [Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset Zhouyi Zhou
2012-05-14 12:20 ` Kevin Wolf
2012-06-12 13:33 ` Andreas Färber
2012-06-12 13:44 ` Kevin Wolf
2012-10-12 15:52 ` Andreas Färber
2012-10-15 9:13 ` Kevin Wolf
2012-10-15 14:28 ` Andreas Färber
2012-10-15 14:46 ` Kevin Wolf
2012-10-16 3:32 ` 周洲仪
2012-11-09 17:21 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509D3B8B.8050900@suse.de \
--to=afaerber@suse.de \
--cc=brogers@suse.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=yizhouzhou@ict.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).