From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TX6r7-0003Z7-GH for qemu-devel@nongnu.org; Sat, 10 Nov 2012 03:56:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TX6r4-0002Pe-EJ for qemu-devel@nongnu.org; Sat, 10 Nov 2012 03:55:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TX6r4-0002PY-6v for qemu-devel@nongnu.org; Sat, 10 Nov 2012 03:55:54 -0500 Message-ID: <509E1695.20705@redhat.com> Date: Sat, 10 Nov 2012 09:55:49 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <509CBE3A.4040103@redhat.com> <509E10AD.2030602@wiesinger.com> In-Reply-To: <509E10AD.2030602@wiesinger.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerhard Wiesinger Cc: "qemu-devel@nongnu.org" Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto: >>> 2.) Added debug code to block.c and to block/vmdk.c to verify >>> correctness >> Same here. Also, please use the tracing infrastructure---a lot of the >> debug >> messages you're adding, though not all, are in fact already available >> (not >> saying the others aren't useful!) > > Any chance that the patch with debug code only (after some cleaning) > would be accepted (other modules do debug logging, too)? > I don't like to do useless work. > Tracing infrastructure is quite limited to function calls only (as far > as I saw). No, tracing infrastructure uses function calls for tracing (messages go into trace-events) but you can apply it to everything you want. Use the stderr backend to debug it. Debug patches using traces are certainly welcome. Paolo