From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJjcJ-0004sg-0J for qemu-devel@nongnu.org; Fri, 18 May 2018 13:56:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJjcI-00083g-EY for qemu-devel@nongnu.org; Fri, 18 May 2018 13:56:35 -0400 References: <20180518132114.4070-1-kwolf@redhat.com> <20180518132114.4070-13-kwolf@redhat.com> From: John Snow Message-ID: <509afafd-54ac-46ef-5609-a019c02bcfe0@redhat.com> Date: Fri, 18 May 2018 13:56:28 -0400 MIME-Version: 1.0 In-Reply-To: <20180518132114.4070-13-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 12/40] job: Move defer_to_main_loop to Job List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com On 05/18/2018 09:20 AM, Kevin Wolf wrote: > Move the defer_to_main_loop functionality from BlockJob to Job. > > The code can be simplified because we can use job->aio_context in > job_defer_to_main_loop_bh() now, instead of having to access the > BlockDriverState. > > Probably taking the data->aio_context lock in addition was already > unnecessary in the old code because we didn't actually make use of > anything protected by the old AioContext except getting the new > AioContext, in case it changed between scheduling the BH and running it. > But it's certainly unnecessary now that the BDS isn't accessed at all > any more. > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz Reviewed-by: John Snow