From: Gerd Hoffmann <kraxel@redhat.com>
To: Marek Vasut <marex@denx.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>,
Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC
Date: Mon, 12 Nov 2012 10:38:45 +0100 [thread overview]
Message-ID: <50A0C3A5.6020100@redhat.com> (raw)
In-Reply-To: <201211101754.36092.marex@denx.de>
Hi,
>> I'd go for clipping rather than asserting too (no crash) in all layers
>> as a defensive approach (console.c/vnc.c).
>
> Won't that be an unnecessary slowdown?
Thats why I tend to prefer assert for additional sanity checks. They
help finding bugs, but can optionally be compiled out.
But adding new asserts just before a release isn't the smartest move
indeed, maybe clip now and turn the checks into asserts once 1.3 is out
of the door.
cheers,
Gerd
next prev parent reply other threads:[~2012-11-12 9:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 20:06 [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC Gerhard Wiesinger
2012-11-04 10:28 ` Gerhard Wiesinger
2012-11-08 18:53 ` Gerhard Wiesinger
2012-11-08 19:09 ` Peter Maydell
2012-11-08 21:07 ` Gerd Hoffmann
2012-11-08 23:55 ` BALATON Zoltan
2012-11-09 9:00 ` Michael Tokarev
2012-11-09 9:06 ` Michael Tokarev
2012-11-09 7:13 ` Gerhard Wiesinger
2012-11-09 7:18 ` Peter Maydell
2012-11-09 9:42 ` Anthony Liguori
2012-11-09 9:50 ` Peter Maydell
2012-11-09 13:31 ` Gerd Hoffmann
2012-11-09 23:45 ` Marek Vasut
2012-11-09 23:52 ` Peter Maydell
2012-11-10 7:45 ` Gerhard Wiesinger
2012-11-10 16:54 ` Marek Vasut
2012-11-12 9:38 ` Gerd Hoffmann [this message]
2012-11-12 9:33 ` Gerd Hoffmann
2012-11-12 11:45 ` BALATON Zoltan
2012-11-10 13:47 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A0C3A5.6020100@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lists@wiesinger.com \
--cc=marex@denx.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).