From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TXqTo-0004JP-BB
	for qemu-devel@nongnu.org; Mon, 12 Nov 2012 04:38:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TXqTl-00015k-8l
	for qemu-devel@nongnu.org; Mon, 12 Nov 2012 04:38:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9454)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TXqTl-00015g-1M
	for qemu-devel@nongnu.org; Mon, 12 Nov 2012 04:38:53 -0500
Message-ID: <50A0C3A5.6020100@redhat.com>
Date: Mon, 12 Nov 2012 10:38:45 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <alpine.LFD.2.02.1211012105080.690@bbs.intern>
	<CAFEAcA_QN7jFSrKbQbXxv+XN9bvKx1=si9iS9GiycHnupJfoOw@mail.gmail.com>
	<509E0603.5060709@wiesinger.com> <201211101754.36092.marex@denx.de>
In-Reply-To: <201211101754.36092.marex@denx.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marek Vasut <marex@denx.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

  Hi,

>> I'd go for clipping rather than asserting too (no crash) in all layers
>> as a defensive approach (console.c/vnc.c).
> 
> Won't that be an unnecessary slowdown?

Thats why I tend to prefer assert for additional sanity checks.  They
help finding bugs, but can optionally be compiled out.

But adding new asserts just before a release isn't the smartest move
indeed, maybe clip now and turn the checks into asserts once 1.3 is out
of the door.

cheers,
  Gerd