qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Workaround for older versions of MinGW gcc
Date: Mon, 12 Nov 2012 11:06:07 +0100	[thread overview]
Message-ID: <50A0CA0F.102@redhat.com> (raw)
In-Reply-To: <20121105055739.GA2452@stefanha-thinkpad.redhat.com>

Am 05.11.2012 06:57, schrieb Stefan Hajnoczi:
> On Sun, Nov 04, 2012 at 12:09:34PM +0100, Stefan Weil wrote:
>> Versions before gcc-4.6 don't support unnamed fields in initializers
>> (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676).
>>
>> Offset and OffsetHigh belong to an unnamed struct which is part of an
>> unnamed union. Therefore the original code does not work with older
>> versions of gcc.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>
>> This patch is needed for Debian's amd64-mingw32msvc-gcc-4.4.4
>> which I use for MinGW-w64 cross compilation.
>>
>> Regards
>> Stefan W.
>>
>>  block/win32-aio.c |   10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2012-11-12 10:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04 11:09 [Qemu-devel] [PATCH] block: Workaround for older versions of MinGW gcc Stefan Weil
2012-11-05  5:57 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-11-12 10:06   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A0CA0F.102@redhat.com \
    --to=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).