From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXquL-0005Bh-Oj for qemu-devel@nongnu.org; Mon, 12 Nov 2012 05:06:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXquI-0000K3-MH for qemu-devel@nongnu.org; Mon, 12 Nov 2012 05:06:21 -0500 Message-ID: <50A0CA0F.102@redhat.com> Date: Mon, 12 Nov 2012 11:06:07 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1352027374-30796-1-git-send-email-sw@weilnetz.de> <20121105055739.GA2452@stefanha-thinkpad.redhat.com> In-Reply-To: <20121105055739.GA2452@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Workaround for older versions of MinGW gcc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel@nongnu.org, Paolo Bonzini Am 05.11.2012 06:57, schrieb Stefan Hajnoczi: > On Sun, Nov 04, 2012 at 12:09:34PM +0100, Stefan Weil wrote: >> Versions before gcc-4.6 don't support unnamed fields in initializers >> (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676). >> >> Offset and OffsetHigh belong to an unnamed struct which is part of an >> unnamed union. Therefore the original code does not work with older >> versions of gcc. >> >> Signed-off-by: Stefan Weil >> --- >> >> This patch is needed for Debian's amd64-mingw32msvc-gcc-4.4.4 >> which I use for MinGW-w64 cross compilation. >> >> Regards >> Stefan W. >> >> block/win32-aio.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) > > Reviewed-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin