From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling
Date: Mon, 12 Nov 2012 11:42:42 +0100 [thread overview]
Message-ID: <50A0D2A2.8000703@redhat.com> (raw)
In-Reply-To: <50A0D16E.7070901@redhat.com>
Am 12.11.2012 11:37, schrieb Paolo Bonzini:
> Il 12/11/2012 11:34, Kevin Wolf ha scritto:
>>> Note that the change from g_malloc0() to g_slice_alloc() should be safe
>>> since the freelist reuse case doesn't zero the AIOCB either.
>>
>> Of course the real reason is that all fields are set anyway.
>
> This doesn't necessarily apply for "subclasses", though. (It does for
> the reason Stefan mentioned, but it is not possible to make it apparent
> in the code).
See? I really shouldn't review code any more. :-)
Kevin
next prev parent reply other threads:[~2012-11-12 10:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 15:34 [Qemu-devel] [PATCH v2 0/3] aio: use g_slice_alloc() for AIOCB pooling Stefan Hajnoczi
2012-10-31 15:34 ` [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t Stefan Hajnoczi
2012-11-02 14:49 ` Paolo Bonzini
2012-10-31 15:34 ` [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling Stefan Hajnoczi
2012-11-02 14:49 ` Paolo Bonzini
2012-11-12 10:34 ` Kevin Wolf
2012-11-12 10:37 ` Paolo Bonzini
2012-11-12 10:42 ` Kevin Wolf [this message]
2012-10-31 15:34 ` [Qemu-devel] [PATCH v2 3/3] aio: rename AIOPool to AIOCBInfo Stefan Hajnoczi
2012-11-02 14:50 ` Paolo Bonzini
2012-11-12 10:34 ` [Qemu-devel] [PATCH v2 0/3] aio: use g_slice_alloc() for AIOCB pooling Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A0D2A2.8000703@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).