From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXrTe-0006Qf-2D for qemu-devel@nongnu.org; Mon, 12 Nov 2012 05:42:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXrTb-0005m4-0H for qemu-devel@nongnu.org; Mon, 12 Nov 2012 05:42:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXrTa-0005m0-P3 for qemu-devel@nongnu.org; Mon, 12 Nov 2012 05:42:46 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qACAgjaS015874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 Nov 2012 05:42:46 -0500 Message-ID: <50A0D2A2.8000703@redhat.com> Date: Mon, 12 Nov 2012 11:42:42 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1351697677-31598-1-git-send-email-stefanha@redhat.com> <1351697677-31598-3-git-send-email-stefanha@redhat.com> <50A0D09B.5080202@redhat.com> <50A0D16E.7070901@redhat.com> In-Reply-To: <50A0D16E.7070901@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 12.11.2012 11:37, schrieb Paolo Bonzini: > Il 12/11/2012 11:34, Kevin Wolf ha scritto: >>> Note that the change from g_malloc0() to g_slice_alloc() should be safe >>> since the freelist reuse case doesn't zero the AIOCB either. >> >> Of course the real reason is that all fields are set anyway. > > This doesn't necessarily apply for "subclasses", though. (It does for > the reason Stefan mentioned, but it is not possible to make it apparent > in the code). See? I really shouldn't review code any more. :-) Kevin