From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXsA3-0003Qu-Si for qemu-devel@nongnu.org; Mon, 12 Nov 2012 06:26:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXsA0-0003Ao-QZ for qemu-devel@nongnu.org; Mon, 12 Nov 2012 06:26:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXsA0-0003Ak-Is for qemu-devel@nongnu.org; Mon, 12 Nov 2012 06:26:36 -0500 Message-ID: <50A0DCE8.3080204@redhat.com> Date: Mon, 12 Nov 2012 12:26:32 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1352718766-5663-1-git-send-email-lma@suse.com> <20121112111828.GL19606@redhat.com> In-Reply-To: <20121112111828.GL19606@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Lin Ma Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >> > QEMU doesn't check if there are mac collisions when adding nics. >> > It causes mac address collisions in guest if adding the nics which >> > include existing physical address. >> > This patch fixes the issue. > I understand the issue, but are there not use cases where it is > reasonable to have multiple NICs with the same MAC address ? To > me this kind of policy enforcement belongs at a higher level in > the mgmt stack. I agree. Paolo