From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXtgm-0001XO-AA for qemu-devel@nongnu.org; Mon, 12 Nov 2012 08:04:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXtgj-0006PE-5k for qemu-devel@nongnu.org; Mon, 12 Nov 2012 08:04:32 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:32913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXtgj-0006NX-1Y for qemu-devel@nongnu.org; Mon, 12 Nov 2012 08:04:29 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Nov 2012 08:04:20 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id DB8E86E803F for ; Mon, 12 Nov 2012 08:04:15 -0500 (EST) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qACD4BRV188568 for ; Mon, 12 Nov 2012 08:04:13 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qACD4A6O015065 for ; Mon, 12 Nov 2012 08:04:11 -0500 Message-ID: <50A0F3CA.5090009@linux.vnet.ibm.com> Date: Mon, 12 Nov 2012 08:04:10 -0500 From: Stefan Berger MIME-Version: 1.0 References: <1338838668-7544-1-git-send-email-stefanb@linux.vnet.ibm.com> <1338838668-7544-2-git-send-email-stefanb@linux.vnet.ibm.com> <50645EDF.8060105@linux.vnet.ibm.com> <50883C48.5090607@linux.vnet.ibm.com> <509BD554.1080708@linux.vnet.ibm.com> In-Reply-To: <509BD554.1080708@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V19 1/7] Support for TPM command line options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: andreas.niederl@iaik.tugraz.at, qemu-devel@nongnu.org, anthony@codemonkey.ws, mst@redhat.com On 11/08/2012 10:52 AM, Corey Bryant wrote: > > > On 10/24/2012 03:06 PM, Stefan Berger wrote: >> On 09/27/2012 10:12 AM, Corey Bryant wrote: >>> >>> >>> On 06/04/2012 03:37 PM, Stefan Berger wrote: >> >>>> + if (!QLIST_EMPTY(&tpm_backends)) { >>>> + error_report("Only one TPM is allowed.\n"); >>>> + return 1; >>>> + } >>> >>> A list of tpm_backends is maintained and walked in a few places, but >>> only one is allowed to be added to the list. Will it ever make sense >>> to enable multiple backends at one time? >>> >> >> A list is also returned through the monitor. This list can at the moment >> only have maximum of one entry. I would keep that list there unless >> someone else opposes. It may be possible to create different types of >> hardware emulation interfaces or simply replicate the TPM TIS at >> different addresses. So I cannot say whether it will 'ever make sense' >> to do that but I'd rather keep the opportunity there than close it and >> with that also let the monitor return a list of items rather than a >> single item. >> >> I removed the processing of the lists in this part of the code at least. >> > > Ok and it doesn't hurt to keep the list processing. In that case you > might as well keep the list processing code everywhere that you > already have it. > I was only going to keep it in the monitor part now... + */ >>>> +int tpm_config_parse(QemuOptsList *opts_list, const char *optarg) >>>> +{ >>>> + QemuOpts *opts; >>>> + >>>> + if (strcmp("none", optarg) != 0) { >>> >>> What's the point of supporting "-tpmdev none"? >>> >> >> Removed. >> > > There must have been a reason you added it in the first place that I'm > just not aware of. Did someone else suggest adding it? Not that I can remember.The option would have been useful if every VM by default had a TPM, similar to the physical world today, but it's unlikely that this will happen. Regards, Stefan