From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TY1id-0006Nv-VI
	for qemu-devel@nongnu.org; Mon, 12 Nov 2012 16:39:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TY1ia-00051v-Rz
	for qemu-devel@nongnu.org; Mon, 12 Nov 2012 16:38:59 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54676 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TY1ia-0004ub-Ls
	for qemu-devel@nongnu.org; Mon, 12 Nov 2012 16:38:56 -0500
Message-ID: <50A16C66.8040907@suse.de>
Date: Mon, 12 Nov 2012 22:38:46 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1352473012-20500-1-git-send-email-ehabkost@redhat.com>
	<1352473012-20500-2-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1352473012-20500-2-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to
	main directory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, riku.voipio@linaro.org
Cc: blauwirbel@gmail.com, Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, peter.maydell@linaro.org

Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> The bsd-user/qemu-types.h and linux-user/qemu-types.h files are almost
> the same, but linux-user have the additional definitions of tswapal().
>=20
> This moves the linux-user file to the main directory, so the same file
> can be used by linux-user and bsd-user.
>=20
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

A quick diff -u confirms that this is (still) the case. I had suggested
unifying these files long time ago when I tried fixing darwin-user, but
hit resistance in favor of having the *-users separate. I'm still in
favor of not duplicating identical code, so

Acked-by: Andreas F=E4rber <afaerber@suse.de>

Riku, do you agree?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg