From: Paolo Bonzini <pbonzini@redhat.com>
To: Charles Arnold <carnold@suse.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field
Date: Tue, 13 Nov 2012 11:45:34 +0100 [thread overview]
Message-ID: <50A224CE.5080708@redhat.com> (raw)
In-Reply-To: <50A0E8C20200009100082E55@novprvoes0310.provo.novell.com>
Il 12/11/2012 20:17, Charles Arnold ha scritto:
> Ping?
>
> Is this ok?
>
> - Charles
>
>>>> On 11/2/2012 at 09:54 AM, in message <50A0E829.5B74.0091.0@suse.com>, Charles
> Arnold wrote:
>> block/vpc: Initialize the uuid field in the footer with a generated uuid.
>>
>> Signed-off-by: Charles Arnold <carnold@suse.com>
>>
>> diff --git a/block/vpc.c b/block/vpc.c
>> index b6bf52f..f14c6ae 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -26,6 +26,9 @@
>> #include "block_int.h"
>> #include "module.h"
>> #include "migration.h"
>> +#if defined(CONFIG_UUID)
>> +#include <uuid/uuid.h>
>> +#endif
>>
>> /**************************************************************/
>>
>> @@ -739,7 +742,9 @@ static int vpc_create(const char *filename,
>> QEMUOptionParameter *options)
>>
>> footer->type = be32_to_cpu(disk_type);
>>
>> - /* TODO uuid is missing */
>> +#if defined(CONFIG_UUID)
>> + uuid_generate(footer->uuid);
>> +#endif
>>
>> footer->checksum = be32_to_cpu(vpc_checksum(buf, HEADER_SIZE));
>>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2012-11-13 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 19:17 [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field Charles Arnold
2012-11-13 10:45 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-02 15:54 Charles Arnold
2012-11-19 11:42 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A224CE.5080708@redhat.com \
--to=pbonzini@redhat.com \
--cc=carnold@suse.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).