From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYF21-0000fA-0e
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 06:51:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYF1x-0008Ko-Tr
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 06:51:52 -0500
Received: from cantor2.suse.de ([195.135.220.15]:50796 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYF1x-0008Kc-L6
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 06:51:49 -0500
Message-ID: <50A2344F.3000800@suse.de>
Date: Tue, 13 Nov 2012 12:51:43 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1334421743-31146-1-git-send-email-peter.maydell@linaro.org>
	<1334421743-31146-3-git-send-email-peter.maydell@linaro.org>
	<20121112221619.GH8231@otherpad.lan.raisama.net>
	<CAFEAcA-1xQxhojcqiK02hA1C7xJ734bK9VjFkWR4juUUeFFrQg@mail.gmail.com>
	<20121112223342.GK3149@otherpad.lan.raisama.net>
In-Reply-To: <20121112223342.GK3149@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses
 for each ARM cpu implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, patches@linaro.org, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

Am 12.11.2012 23:33, schrieb Eduardo Habkost:
> On Mon, Nov 12, 2012 at 10:18:29PM +0000, Peter Maydell wrote:
>> On 12 November 2012 22:16, Eduardo Habkost <ehabkost@redhat.com> wrote=
:
>>> On Sat, Apr 14, 2012 at 05:42:10PM +0100, Peter Maydell wrote:
>>>> +static const ARMCPUInfo arm_cpus[] =3D {
>>> [...]
>>>> +    { .name =3D "any",         .initfn =3D arm_any_initfn },
>>>> +};
>>>> +
>>>
>>> Do we really want to use "any" as the class name?
>>
>> Probably not, since it would make it tricky to (in some future
>> utopia) have a QEMU which supported more than one CPU architecture
>> in the same binary if they all wanted to use "any"...
>=20
> In that case, "cpu-any" wouldn't work, either. What about
> "<arch>-cpu-<model>"?

Fine with me. However, keep in mind the previous approach was used for
command line compatibility: I would like to continue using -cpu
cortex-a9 rather than -cpu arm-cpu-cortex-a9. :)

If we introduce a more complex command-line-to-class mapping, can't we
drop these ominous "any" CPUs altogether? For my understanding they were
used as wildcard CPUs for *-user. We could do the same by instantiating
a real CPU like "cortex-a15" and possibly enabling some additional
features afterwards.

Andreas

>>> Maybe we should use
>>> "cpu-<model>" as the namespace for the CPU model class names?
>>
>> Sounds reasonable.
>>
>> -- PMM

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg