From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYXPL-0007FO-D2 for qemu-devel@nongnu.org; Wed, 14 Nov 2012 02:29:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYXPI-0007nM-B0 for qemu-devel@nongnu.org; Wed, 14 Nov 2012 02:29:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYXPH-0007n8-UQ for qemu-devel@nongnu.org; Wed, 14 Nov 2012 02:29:08 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAE7T6uQ008511 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 14 Nov 2012 02:29:07 -0500 Message-ID: <50A3483F.9080304@redhat.com> Date: Wed, 14 Nov 2012 08:29:03 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1352821889-24150-1-git-send-email-kwolf@redhat.com> <50A285DB.8020107@redhat.com> In-Reply-To: <50A285DB.8020107@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] Fix qemu_aio_flush callers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 13.11.2012 18:39, schrieb Paolo Bonzini: > Il 13/11/2012 16:51, Kevin Wolf ha scritto: >> This series has two patches that fixes current qemu_aio_flush() callers, which >> should call bdrv_drain_all() instead. The other two patches are for changing >> the coroutine request cancellation to waiting for a single request (Paolo >> didn't want to change this to bdrv_drain_all()) and removing qemu_aio_flush() >> altogether in order to avoid future misuse. >> >> Kevin Wolf (4): >> block: Improve bdrv_aio_co_cancel_em >> megasas: Use bdrv_drain_all instead of qemu_aio_flush >> qemu-io: Use bdrv_drain_all instead of qemu_aio_flush >> aio: Get rid of qemu_aio_flush() >> >> async.c | 5 ----- >> block.c | 19 ++++++++++++++++++- >> block/commit.c | 2 +- >> block/mirror.c | 2 +- >> block/stream.c | 2 +- >> hw/megasas.c | 2 +- >> main-loop.c | 5 ----- >> qemu-aio.h | 9 ++------- >> qemu-io.c | 2 +- >> 9 files changed, 25 insertions(+), 23 deletions(-) >> > > Patches 2 and 3 look good. The rest is 1.4 material, looks good but > maybe we can do something better than the ->done boolean... no ideas, > just thinking out loud, but perhaps it will come out naturally of the > AioContext/data-plane work. At the moment I can't see how, but if it does, we can still replace it. I just don't think that the old paths go away in the very near future, so I'd prefer not waiting for the data-plane work to be completed. Kevin