From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54998)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TYZGH-0003uS-Cj
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 04:28:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TYZGE-0001mw-BH
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 04:27:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TYZGE-0001mr-3T
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 04:27:54 -0500
Message-ID: <50A358FE.6000101@redhat.com>
Date: Wed, 14 Nov 2012 09:40:30 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1352796133-956-1-git-send-email-kraxel@redhat.com>
	<1352796133-956-2-git-send-email-kraxel@redhat.com>
	<50A28A25.6050500@weilnetz.de>
In-Reply-To: <50A28A25.6050500@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On 11/13/12 18:57, Stefan Weil wrote:
> Am 13.11.2012 09:42, schrieb Gerd Hoffmann:
>> Needed to make sure the (generated) pixman-version.h file is found.
>> Based on a patch from Blue Swirl.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>   configure |    6 +++---
>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 7290f50..18faded 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2121,8 +2121,9 @@ else
>>       echo "      git submodule update --init pixman"
>>       exit 1
>>     fi
>> -  pixman_cflags="-I${source_path}/pixman/pixman"
>> -  pixman_libs="-Lpixman/pixman/.libs -lpixman-1"
>> +  mkdir -p pixman/pixman
>> +  pixman_cflags="-I${source_path}/pixman/pixman -I$(pwd)/pixman/pixman"
>> +  pixman_libs="-L$(pwd)/pixman/pixman/.libs -lpixman-1"
> 
> I'd prefer \$(BUILD_DIR) instead of $(pwd) for cflags and libs
> because it allows moving the build directory.

It isn't that simple.  Blue Swirl had it that way initially.  The
problem is that pixman_cflags is added to QEMU_CFLAGS, which in turn is
used by configure script checks too, which then blow up because make and
shell interpret "$(BUILD_DIR)" in different ways ...

cheers,
  Gerd