qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path
Date: Wed, 14 Nov 2012 13:33:05 +0100	[thread overview]
Message-ID: <50A38F81.4090308@redhat.com> (raw)
In-Reply-To: <50A358FE.6000101@redhat.com>

On 11/14/12 09:40, Gerd Hoffmann wrote:
>>> >> +  pixman_cflags="-I${source_path}/pixman/pixman -I$(pwd)/pixman/pixman"
>>> >> +  pixman_libs="-L$(pwd)/pixman/pixman/.libs -lpixman-1"

>> > 
>> > I'd prefer \$(BUILD_DIR) instead of $(pwd) for cflags and libs
>> > because it allows moving the build directory.

> It isn't that simple.  Blue Swirl had it that way initially.  The
> problem is that pixman_cflags is added to QEMU_CFLAGS, which in turn is
> used by configure script checks too, which then blow up because make and
> shell interpret "$(BUILD_DIR)" in different ways ...

Moving the lines which update QEMU_CFLAGS down the road, after all
configure checks works though.

cheers,
  Gerd

  reply	other threads:[~2012-11-14 12:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13  8:42 [Qemu-devel] [PULL 0/6] pixman build fixes Gerd Hoffmann
2012-11-13  8:42 ` [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path Gerd Hoffmann
2012-11-13 17:57   ` Stefan Weil
2012-11-14  8:40     ` Gerd Hoffmann
2012-11-14 12:33       ` Gerd Hoffmann [this message]
2012-11-13  8:42 ` [Qemu-devel] [PATCH 2/6] pixman: pass tools to configure Gerd Hoffmann
2012-11-13 17:50   ` Stefan Weil
2012-11-14  8:42     ` Gerd Hoffmann
2012-11-13  8:42 ` [Qemu-devel] [PATCH 3/6] pixman: disable gtk Gerd Hoffmann
2012-11-13 18:27   ` Peter Maydell
2012-11-13  8:42 ` [Qemu-devel] [PATCH 4/6] pixman: add pass cflags, add -fPIC Gerd Hoffmann
2012-11-13 18:28   ` Peter Maydell
2012-11-13  8:42 ` [Qemu-devel] [PATCH 5/6] pixman: build internal version early Gerd Hoffmann
2012-11-13 18:29   ` Peter Maydell
2012-11-13 18:41     ` Johnson, Eric
2012-11-14 12:41       ` Gerd Hoffmann
2012-11-14 18:42         ` Johnson, Eric
2012-11-13  8:42 ` [Qemu-devel] [PATCH 6/6] pixman: add licensing info Gerd Hoffmann
2012-11-13 17:31 ` [Qemu-devel] [PULL 0/6] pixman build fixes Peter Maydell
2012-11-13 18:07   ` Stefan Weil
2012-11-14 16:27 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A38F81.4090308@redhat.com \
    --to=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).