From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYcI9-00069h-Fn for qemu-devel@nongnu.org; Wed, 14 Nov 2012 07:42:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYcI6-0001wR-EF for qemu-devel@nongnu.org; Wed, 14 Nov 2012 07:42:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYcI6-0001wG-6a for qemu-devel@nongnu.org; Wed, 14 Nov 2012 07:42:02 -0500 Message-ID: <50A39193.4090908@redhat.com> Date: Wed, 14 Nov 2012 13:41:55 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1352796133-956-1-git-send-email-kraxel@redhat.com> <1352796133-956-6-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Johnson, Eric" Cc: Peter Maydell , "qemu-devel@nongnu.org" On 11/13/12 19:41, Johnson, Eric wrote: > It's OK to add. > Signed-off-by: Eric Johnson Updated patch. > I wasn't sure how to submit a patch to an unsubmitted patch. As usual: "git commit -s" + "git format-patch" + "git send-email", especially as this one stands on its own and has no dependency on the unsubmitted patch, but it is fine for incremental fixes too. Then I can simply "git am -s" the patch and either carry it on as is or squash in the incremental fix on a case-by-case basis. I tend to carry patches as is, but in some cases squashing can be better for bisectability. cheers, Gerd