From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYdNu-00008I-Pk for qemu-devel@nongnu.org; Wed, 14 Nov 2012 08:52:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYdNr-0001yN-N4 for qemu-devel@nongnu.org; Wed, 14 Nov 2012 08:52:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48054 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYdNr-0001xq-Gi for qemu-devel@nongnu.org; Wed, 14 Nov 2012 08:52:03 -0500 Message-ID: <50A3A1FE.1020306@suse.de> Date: Wed, 14 Nov 2012 14:51:58 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1352473012-20500-1-git-send-email-ehabkost@redhat.com> <1352473012-20500-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1352473012-20500-6-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used in cpu.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org, blauwirbel@gmail.com, Anthony Liguori , Igor Mammedov Am 09.11.2012 15:56, schrieb Eduardo Habkost: > From: Anthony Liguori >=20 > Header file dependency is a frickin' nightmare right now. cpu.h tends = to get > included in our 'include everything' header files but qdev also needs t= o include > those headers mainly for qdev-properties since it knows about CharDrive= rState > and friends. >=20 > We can solve this for now by splitting out qdev.h along the same lines = that we > previously split the C file. Then cpu.h just needs to include qdev-cor= e.h >=20 > hw/qdev.h is split into following new headers: > hw/qdev-core.h > hw/qdev-properties.h > hw/qdev-monitor.h >=20 > Signed-off-by: Anthony Liguori >=20 > [ehabkost: re-add DEFINE_PROP_PCI_HOST_DEVADDR, that was removed on the > original patch (by mistake, I guess)] > [ehabkost: kill qdev_prop_set_vlan() declaration] > [ehabkost: moved get_fw_dev_path() comment to the original location > (I don't know why it was moved)] > [ehabkost: removed qdev_exists() declaration] > [ehabkost: keep using 'QemuOpts' instead of 'struct QemuOpts', as > qdev-core.h includes qemu-option.h] >=20 > Signed-off-by: Eduardo Habkost Yay, I made it through this patch line by line! Perfect now, Acked-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg