From: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/30] migration: stop all cpus correctly
Date: Wed, 14 Nov 2012 16:21:13 +0100 [thread overview]
Message-ID: <50A3B6E9.1020303@redhat.com> (raw)
In-Reply-To: <50A0E123.4040406@redhat.com>
Il 12/11/2012 12:44, Paolo Bonzini ha scritto:
>> @@ -339,7 +351,11 @@ void migrate_fd_put_ready(MigrationState *s)
>> DPRINTF("done iterating\n");
>> start_time = qemu_get_clock_ms(rt_clock);
>> qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER);
>> - vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
>> + if (old_vm_running) {
>> + vm_stop(RUN_STATE_FINISH_MIGRATE);
>> + } else {
>> + vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
>> + }
>>
>> if (qemu_savevm_state_complete(s->file) < 0) {
>> migrate_fd_error(s);
This hunk also seems to be useless nowadays.
Paolo
next prev parent reply other threads:[~2012-11-14 15:21 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 7:29 [Qemu-devel] [PATCH 00/30] Migration thread 20121017 edition Juan Quintela
2012-10-18 7:29 ` [Qemu-devel] [PATCH 01/30] split MRU ram list Juan Quintela
2012-10-21 11:58 ` Orit Wasserman
2012-10-21 17:02 ` Peter Maydell
2012-10-18 7:29 ` [Qemu-devel] [PATCH 02/30] add a version number to ram_list Juan Quintela
2012-10-21 12:00 ` Orit Wasserman
2012-10-18 7:29 ` [Qemu-devel] [PATCH 03/30] protect the ramlist with a separate mutex Juan Quintela
2012-10-21 12:05 ` Orit Wasserman
2012-10-18 7:30 ` [Qemu-devel] [PATCH 04/30] buffered_file: Move from using a timer to use a thread Juan Quintela
2012-10-18 8:56 ` Paolo Bonzini
2012-10-21 12:09 ` Orit Wasserman
2012-11-12 11:42 ` Paolo Bonzini
2012-10-18 7:30 ` [Qemu-devel] [PATCH 05/30] migration: make qemu_fopen_ops_buffered() return void Juan Quintela
2012-10-21 12:10 ` Orit Wasserman
2012-10-18 7:30 ` [Qemu-devel] [PATCH 06/30] migration: stop all cpus correctly Juan Quintela
2012-11-12 11:44 ` Paolo Bonzini
2012-11-14 15:21 ` Paolo Bonzini [this message]
2012-12-14 12:36 ` Juan Quintela
2012-12-14 13:53 ` Paolo Bonzini
2012-10-18 7:30 ` [Qemu-devel] [PATCH 07/30] migration: make writes blocking Juan Quintela
2012-11-12 11:52 ` Paolo Bonzini
2012-10-18 7:30 ` [Qemu-devel] [PATCH 08/30] migration: remove unfreeze logic Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 09/30] migration: take finer locking Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 10/30] buffered_file: Unfold the trick to restart generating migration data Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 11/30] buffered_file: don't flush on put buffer Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 12/30] buffered_file: unfold buffered_append in buffered_put_buffer Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 13/30] savevm: New save live migration method: pending Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 14/30] migration: include qemu-file.h Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 15/30] migration-fd: remove duplicate include Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 16/30] migration: move buffered_file.c code into migration.c Juan Quintela
2012-10-18 8:57 ` Paolo Bonzini
2012-10-18 7:30 ` [Qemu-devel] [PATCH 17/30] migration: move migration_fd_put_ready() Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 18/30] migration: Inline qemu_fopen_ops_buffered into migrate_fd_connect Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 19/30] migration: move migration notifier Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 20/30] migration: move begining stage to the migration thread Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 21/30] migration: move exit condition to " Juan Quintela
2012-10-18 8:34 ` Paolo Bonzini
2012-10-26 11:43 ` Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 22/30] migration: unfold rest of migrate_fd_put_ready() into thread Juan Quintela
2012-10-18 8:39 ` Paolo Bonzini
2012-10-18 8:55 ` Paolo Bonzini
2012-10-18 7:30 ` [Qemu-devel] [PATCH 23/30] migration: print times for end phase Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 24/30] ram: rename last_block to last_seen_block Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 25/30] ram: Add last_sent_block Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 26/30] memory: introduce memory_region_test_and_clear_dirty Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 27/30] ram: Use memory_region_test_and_clear_dirty Juan Quintela
2012-10-18 12:52 ` Eric Blake
2012-10-18 7:30 ` [Qemu-devel] [PATCH 28/30] fix memory.c Juan Quintela
2012-10-18 8:43 ` Paolo Bonzini
2012-10-18 7:30 ` [Qemu-devel] [PATCH 29/30] migration: Only go to the iterate stage if there is anything to send Juan Quintela
2012-10-18 7:30 ` [Qemu-devel] [PATCH 30/30] ram: optimize migration bitmap walking Juan Quintela
2012-10-21 13:01 ` Orit Wasserman
2012-10-26 11:39 ` Juan Quintela
2012-10-28 8:35 ` Orit Wasserman
2012-10-30 10:15 ` Orit Wasserman
2012-10-30 15:33 ` Juan Quintela
2012-10-18 9:00 ` [Qemu-devel] [PATCH 00/30] Migration thread 20121017 edition Paolo Bonzini
2012-10-26 13:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A3B6E9.1020303@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).