From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TYemG-0000mc-3m
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 10:21:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TYemD-0005co-1E
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 10:21:20 -0500
Received: from mail-ea0-f173.google.com ([209.85.215.173]:59395)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TYemC-0005ci-QX
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 10:21:16 -0500
Received: by mail-ea0-f173.google.com with SMTP id i13so247036eaa.4
	for <qemu-devel@nongnu.org>; Wed, 14 Nov 2012 07:21:16 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50A3B6E9.1020303@redhat.com>
Date: Wed, 14 Nov 2012 16:21:13 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1350545426-23172-1-git-send-email-quintela@redhat.com>
	<1350545426-23172-7-git-send-email-quintela@redhat.com>
	<50A0E123.4040406@redhat.com>
In-Reply-To: <50A0E123.4040406@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/30] migration: stop all cpus correctly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

Il 12/11/2012 12:44, Paolo Bonzini ha scritto:
>> @@ -339,7 +351,11 @@ void migrate_fd_put_ready(MigrationState *s)
>>          DPRINTF("done iterating\n");
>>          start_time = qemu_get_clock_ms(rt_clock);
>>          qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER);
>> -        vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
>> +        if (old_vm_running) {
>> +            vm_stop(RUN_STATE_FINISH_MIGRATE);
>> +        } else {
>> +            vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
>> +        }
>> 
>>          if (qemu_savevm_state_complete(s->file) < 0) {
>>              migrate_fd_error(s);

This hunk also seems to be useless nowadays.

Paolo