From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYlex-0001kK-3q for qemu-devel@nongnu.org; Wed, 14 Nov 2012 17:42:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYleu-0008Td-1i for qemu-devel@nongnu.org; Wed, 14 Nov 2012 17:42:15 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42958 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYlet-0008TO-OR for qemu-devel@nongnu.org; Wed, 14 Nov 2012 17:42:11 -0500 Message-ID: <50A41E3D.7050005@suse.de> Date: Wed, 14 Nov 2012 23:42:05 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1352473012-20500-1-git-send-email-ehabkost@redhat.com> <1352473012-20500-16-git-send-email-ehabkost@redhat.com> In-Reply-To: <1352473012-20500-16-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 15/24] qlist.h: do not include qemu-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org, blauwirbel@gmail.com, Anthony Liguori , Igor Mammedov Am 09.11.2012 15:56, schrieb Eduardo Habkost: > I don't know why it was including it, as I don't see any code that > depends on anything from qemu-common.h. >=20 > Signed-off-by: Eduardo Habkost > --- > qlist.h | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/qlist.h b/qlist.h > index ae776f9..7408947 100644 > --- a/qlist.h > +++ b/qlist.h > @@ -15,7 +15,6 @@ > =20 > #include "qobject.h" > #include "qemu-queue.h" > -#include "qemu-common.h" > #include "qemu-queue.h" > =20 > typedef struct QListEntry { CC qga/channel-posix.o /home/andreas/QEMU/qemu-rcar/qga/channel-posix.c: In function =E2=80=98ga_channel_open=E2=80=99: /home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:13: error: implicit declaration of function =E2=80=98exit=E2=80=99 [-Werror=3Dimplicit-functi= on-declaration] /home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:13: error: incompatible implicit declaration of built-in function =E2=80=98exit=E2=80= =99 [-Werror] /home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:18: error: =E2=80=98EXIT_FAILURE=E2=80=99 undeclared (first use in this function) /home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:18: note: each undeclared identifier is reported only once for each function it appears = in /home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:163:13: error: incompatible implicit declaration of built-in function =E2=80=98exit=E2=80= =99 [-Werror] cc1: all warnings being treated as errors make: *** [qga/channel-posix.o] Fehler 1 Sounds related to not doing qemu-stdio.h... Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg