From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors
Date: Thu, 15 Nov 2012 09:28:56 +0100 [thread overview]
Message-ID: <50A4A7C8.8010904@redhat.com> (raw)
In-Reply-To: <50A4A682.2010508@siemens.com>
On 11/15/12 09:23, Jan Kiszka wrote:
> The Linux is more tolerant here as well: Just stop parsing the device
> descriptors when an error is detected but do not reset what was found
> so far. This allows to run buggy devices with partially invalid
> descriptors.
> -error:
> - usb_ep_reset(&s->dev);
> - return 1;
I'd prefer to keep the error jump target to handle the parse error here.
Dumping the reset there is fine with me, but I'd prefer this event being
logged (trace point or stderr message or both) to ease trouble shooting
in case a device doesn't behave as expected.
thanks,
Gerd
next prev parent reply other threads:[~2012-11-15 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 8:23 [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors Jan Kiszka
2012-11-15 8:28 ` Gerd Hoffmann [this message]
2012-11-15 8:31 ` Jan Kiszka
2012-11-15 9:00 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A4A7C8.8010904@redhat.com \
--to=kraxel@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).